feat(docs): tier 2 — dashboard view and save-modal tutorial screenshots#39466
feat(docs): tier 2 — dashboard view and save-modal tutorial screenshots#39466rusackas wants to merge 4 commits intofeat/docs-screenshotsfrom
Conversation
Adds five new Playwright-generated screenshots for the `creating-your-first-dashboard` tutorial: - tutorial_first_dashboard.png: Sales Dashboard content (view mode) - publish_button_dashboard.png: dashboard header with Published badge - tutorial_edit_button.png: isolated Edit dashboard button - tutorial_chart_resize.png: dashboard in edit mode with side panel - tutorial_save_slice.png: Save chart modal from explore Extracts an `openSalesDashboard` helper shared between the existing dashboard test and the new tutorial captures, and updates screenshot-manifest.yaml to remove the five entries that are now scripted (tutorial count: 42 -> 37). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Bito Automatic Review Skipped - Branch Excluded |
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/docs-screenshots #39466 +/- ##
======================================================
Coverage 64.49% 64.49%
======================================================
Files 2557 2557
Lines 133097 133097
Branches 30910 30910
======================================================
Hits 85846 85846
Misses 45761 45761
Partials 1490 1490
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- publish button: toggle to Draft and show the informational tooltip - edit button: include the sibling "..." actions button for context - chart resize: enter edit mode and start a drag to show the blue resize-selection outline on a chart - save flow + first dashboard: merged into a single test that saves a Scatter Plot to a newly-created "Superset Duper Sales Dashboard" and captures both the save modal (creatable dropdown option) and the resulting fresh single-chart dashboard. Uses the API to clean up the created dashboard and its chart, including idempotent pre-cleanup to recover from failed prior runs Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
- chart resize: target the right-edge handle directly via its class and move further so the grid enters isResizing, rendering the vertical column guides and the chart's --resizing outline. Clip to a single chart + hover action rail to match the original tutorial framing. - first dashboard: clip width to the chart's right edge + padding so the screenshot doesn't include empty grid space to the right. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
SUMMARY
Tier 2 of the living docs:screenshots system (stacked on #39444). Adds five Playwright-generated screenshots from the Creating your first dashboard tutorial:
tutorial_first_dashboard.pngpublish_button_dashboard.pngtutorial_edit_button.pngtutorial_chart_resize.pngtutorial_save_slice.pngRefactors the existing
dashboard screenshottest to share anopenSalesDashboardhelper with the three new dashboard-based tests.Removes the five captured entries from
screenshot-manifest.yaml(tutorial count 42 → 37).BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
The five updated images in
docs/static/img/tutorial/are the before/after.TESTING INSTRUCTIONS
cd superset-frontendPLAYWRIGHT_BASE_URL=http://localhost:8088 PLAYWRIGHT_ADMIN_PASSWORD=admin npm run docs:screenshotsdocs/static/img/tutorial/regenerate cleanlyADDITIONAL INFORMATION
Stacked on #39444 — once that merges, this PR's base will rebase onto master.
🤖 Generated with Claude Code