fix(deploy): prevent double-prefix of logo URL in subdirectory deployments by Abdulrehman-PIAIC80387 · Pull Request #39472 · apache/superset

Abdulrehman-PIAIC80387 · 2026-04-20T06:21:53Z

SUMMARY

When deploying Superset under a subdirectory (e.g. SUPERSET_APP_ROOT=/dashboards), the logo image returns a 404 because the URL is double-prefixed:

/dashboards/dashboards/static/assets/images/superset-logo-horiz.png

Root cause

Two independent mechanisms each add the app_root prefix:

Backend — superset/app.py (introduced in fix: add subdirectory deployment support for app icon and reports urls #35098) manually prefixes APP_ICON, brandLogoUrl, and brandLogoHref with app_root.
Frontend — ensureStaticPrefix() in superset-frontend/src/utils/assetUrl.ts and ensureAppRoot() in src/utils/pathUtils.ts also prepend app_root to any path starting with / when rendering these values in Menu.tsx.

Since both mechanisms run independently, the prefix is applied twice.

Fix

Remove the manual backend prefixing block in superset/app.py. The frontend helpers already handle subdirectory deployments correctly:

brand.icon → ensureStaticPrefix (Menu.tsx)
theme.brandLogoUrl → ensureStaticPrefix (Menu.tsx)
theme.brandLogoHref → ensureAppRoot (Menu.tsx)

Related issues

Fixes Subdirectory deployment: logo double-prefixed when using SUPERSET_APP_ROOT #39432
Fixes Logo double-prefixed in subdirectory deploy xhcarina/superset#4 (duplicate)

BEFORE / AFTER SCREENSHOTS OR ANIMATED GIF

Before — Logo is broken (404) when deployed under /dashboards. Network request shows .

After — Logo loads correctly. Network request shows /dashboards/static/... (single prefix).

TESTING INSTRUCTIONS

Set APPLICATION_ROOT = "/dashboards" (or SUPERSET_APP_ROOT=/dashboards) in your config
Start Superset
Open http://localhost:8088/dashboards/
Verify the Superset logo loads correctly (not a broken image)
In DevTools → Network tab, confirm the logo request URL is /dashboards/static/assets/images/superset-logo-horiz.png (single /dashboards/ prefix)

ADDITIONAL INFORMATION

Has associated issue: Fixes Subdirectory deployment: logo double-prefixed when using SUPERSET_APP_ROOT #39432
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

…logo to prevent double-prefix in subdirectory deployments Fixes apache#39432 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

bito-code-review · 2026-04-20T06:22:04Z

Code Review Agent Run #c5c7e7

Actionable Suggestions - 0

Review Details

Files reviewed - 1 · Commit Range: fd3e5ae..fd3e5ae
- superset/app.py
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
- MyPy (Static Code Analysis) - ✔︎ Successful
- Astral Ruff (Static Code Analysis) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

codecov · 2026-04-20T06:25:31Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.49%. Comparing base (fbd0621) to head (708de55).

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #39472   +/-   ##
=======================================
  Coverage   64.49%   64.49%           
=======================================
  Files        2557     2557           
  Lines      133191   133182    -9     
  Branches    30935    30931    -4     
=======================================
  Hits        85897    85897           
+ Misses      45804    45795    -9     
  Partials     1490     1490

Flag	Coverage Δ
hive	`39.88% <ø> (+<0.01%)`	⬆️
mysql	`60.50% <ø> (+<0.01%)`	⬆️
postgres	`60.59% <ø> (+<0.01%)`	⬆️
presto	`41.66% <ø> (+<0.01%)`	⬆️
python	`62.17% <ø> (+<0.01%)`	⬆️
sqlite	`60.22% <ø> (+<0.01%)`	⬆️
unit	`100.00% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

netlify · 2026-04-20T06:26:06Z

✅ Deploy Preview for superset-docs-preview ready!

Name	Link
🔨 Latest commit	`708de55`
🔍 Latest deploy log	https://app.netlify.com/projects/superset-docs-preview/deploys/69e5ec1a52a6770008022dbe
😎 Deploy Preview	https://deploy-preview-39472--superset-docs-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

…logo-double-prefix-39432

Abdulrehman-PIAIC80387 · 2026-04-21T08:59:17Z

Hi @rusackas @michael-s-molina @aminghadersohi — when you have a moment, mind taking a look? CI is green and the fix is small (just removes redundant backend prefixing since the frontend already handles it via ensureStaticPrefix/ensureAppRoot). Happy to address any feedback.

onionhammer · 2026-04-28T17:24:38Z

Getting an issue with RC2 specifying a URL to /static/assets/custom/my_logo.svg

i.e.

THEME_DEFAULT = {
    "token": {
        "brandLogoUrl": "/static/assets/custom/my_logo.svg"
    }
}

Causes error boostrapping the frontend

installHook.js:1 Unhandled error during app initialization TypeError: Cannot read properties of undefined (reading 'startsWith')
at n (8100.01fbde9ef08d98862d13.entry.js:8:21542)
at es (3264.df020978441f8a642d17.entry.js:735:950)
at ii (vendors.cba714126ad1ea16d814.entry.js:550:51407)
at c (vendors.cba714126ad1ea16d814.entry.js:554:21698)
at a3 (vendors.cba714126ad1ea16d814.entry.js:554:872)
at a4 (vendors.cba714126ad1ea16d814.entry.js:554:742)
at aY (vendors.cba714126ad1ea16d814.entry.js:552:11364)
at aq (vendors.cba714126ad1ea16d814.entry.js:552:8686)
at lg (vendors.cba714126ad1ea16d814.entry.js:554:19014)
at vendors.cba714126ad1ea16d814.entry.js:554:20399

Abdulrehman-PIAIC80387 · 2026-04-28T17:44:15Z

Thanks @onionhammer — this looks like a separate bug. Your crash is from theme.brandLogoHref being undefined (overriding THEME_DEFAULT in your config drops the default). This PR is a backend-only fix for the double-prefix issue, so it won't address yours.

rusackas

LGTM!

…ments (apache#39472) Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

fix(deploy): remove redundant app_root prefix for APP_ICON and brand …

fd3e5ae

…logo to prevent double-prefix in subdirectory deployments Fixes apache#39432 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

pull-request-size Bot added the size/S label Apr 20, 2026

dosubot Bot added the change:backend Requires changing the backend label Apr 20, 2026

Merge remote-tracking branch 'upstream/master' into fix/subdirectory-…

708de55

…logo-double-prefix-39432

rusackas reviewed May 12, 2026

View reviewed changes

rusackas self-requested a review May 12, 2026 04:13

rusackas approved these changes May 12, 2026

View reviewed changes

rusackas merged commit fed29b3 into apache:master May 12, 2026
65 checks passed

qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026

fix(deploy): prevent double-prefix of logo URL in subdirectory deploy…

2e5b655

…ments (apache#39472) Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(deploy): prevent double-prefix of logo URL in subdirectory deployments#39472

fix(deploy): prevent double-prefix of logo URL in subdirectory deployments#39472
rusackas merged 2 commits into
apache:masterfrom
Abdulrehman-PIAIC80387:fix/subdirectory-logo-double-prefix-39432

Abdulrehman-PIAIC80387 commented Apr 20, 2026 •

edited

Loading

Uh oh!

bito-code-review Bot commented Apr 20, 2026 •

edited

Loading

Code Review Agent Run #c5c7e7

Uh oh!

codecov Bot commented Apr 20, 2026 •

edited

Loading

Uh oh!

netlify Bot commented Apr 20, 2026 •

edited

Loading

Uh oh!

Abdulrehman-PIAIC80387 commented Apr 21, 2026

Uh oh!

onionhammer commented Apr 28, 2026

Uh oh!

Abdulrehman-PIAIC80387 commented Apr 28, 2026

Uh oh!

rusackas left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Abdulrehman-PIAIC80387 commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SUMMARY

Root cause

Fix

Related issues

BEFORE / AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Uh oh!

bito-code-review Bot commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #c5c7e7

Uh oh!

codecov Bot commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

netlify Bot commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for superset-docs-preview ready!

Uh oh!

Abdulrehman-PIAIC80387 commented Apr 21, 2026

Uh oh!

onionhammer commented Apr 28, 2026

Uh oh!

Abdulrehman-PIAIC80387 commented Apr 28, 2026

Uh oh!

rusackas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Abdulrehman-PIAIC80387 commented Apr 20, 2026 •

edited

Loading

bito-code-review Bot commented Apr 20, 2026 •

edited

Loading

codecov Bot commented Apr 20, 2026 •

edited

Loading

netlify Bot commented Apr 20, 2026 •

edited

Loading