fix(charts): show non-filterable columns in metric section for table … by massucattoj · Pull Request #39524 · apache/superset

massucattoj · 2026-04-21T14:43:03Z

SUMMARY

Columns with Is filterable set to NO were not displayed in the metric section of Table, AG Grid Table, and Handlebars charts, even though they were successfully added to the chart config.

The root cause was that the metrics control's mapStateToProps incorrectly filtered columns by the filterable property. The filterable flag should only control whether a column appears in filter controls
(e.g., Filter Bar), not whether it can be used as a metric or dimension.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before: Dragging a non-filterable column into the Metrics section adds it to the form data, but the metric pill is not rendered — the Metrics area appears empty even though the chart recognizes the metric.

After: Non-filterable columns display correctly as metric pills in the Metrics section after being added.

TESTING INSTRUCTIONS

Go to Datasets and edit any dataset (e.g., birth_names)
In the Columns tab, uncheck "Is filterable" for a column (e.g., num)
Save the dataset
Create a new Table chart using that dataset
Drag the non-filterable column from the left sidebar into the Metrics drop zone
In the modal, confirm it shows the correct aggregation (e.g., SUM(num)) and click Save
Verify the metric pill now appears in the Metrics section
Also verify that clicking "Drop columns/metrics here or click" on Metrics shows the column in the Simple tab dropdown
Repeat for Handlebars chart type to confirm the fix there as well

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

bito-code-review · 2026-04-21T14:43:13Z

Code Review Agent Run #fcce81

Actionable Suggestions - 0

Review Details

Files reviewed - 4 · Commit Range: 5dd1d49..5dd1d49
- superset-frontend/plugins/plugin-chart-ag-grid-table/src/controlPanel.tsx
- superset-frontend/plugins/plugin-chart-handlebars/src/plugin/controls/columns.tsx
- superset-frontend/plugins/plugin-chart-handlebars/src/plugin/controls/metrics.tsx
- superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

…charts

bito-code-review · 2026-04-21T16:05:37Z

Code Review Agent Run #fd2c1a

Actionable Suggestions - 0

Review Details

Files reviewed - 4 · Commit Range: d0a3fbc..d0a3fbc
- superset-frontend/plugins/plugin-chart-ag-grid-table/src/controlPanel.tsx
- superset-frontend/plugins/plugin-chart-handlebars/src/plugin/controls/columns.tsx
- superset-frontend/plugins/plugin-chart-handlebars/src/plugin/controls/metrics.tsx
- superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

codecov · 2026-04-26T01:24:24Z

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.21%. Comparing base (965ec47) to head (95ee854).

Files with missing lines	Patch %	Lines
...n-chart-handlebars/src/plugin/controls/columns.tsx	0.00%	1 Missing ⚠️
...n-chart-handlebars/src/plugin/controls/metrics.tsx	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #39524      +/-   ##
==========================================
+ Coverage   64.20%   64.21%   +0.01%     
==========================================
  Files        2592     2592              
  Lines      139232   139223       -9     
  Branches    32327    32323       -4     
==========================================
+ Hits        89389    89403      +14     
+ Misses      48308    48285      -23     
  Partials     1535     1535

Flag	Coverage Δ
javascript	`67.36% <50.00%> (+0.02%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

msyavuz

Looks fine to me but @amaannawab923 might have an insight here on why this exists. Also some tests would be nice

bito-code-review · 2026-05-04T12:30:00Z

Code Review Agent Run #e3b9ca

Actionable Suggestions - 0

Review Details

Files reviewed - 2 · Commit Range: d0a3fbc..deec9f4
- superset-frontend/plugins/plugin-chart-ag-grid-table/test/controlPanel.test.tsx
- superset-frontend/plugins/plugin-chart-table/test/controlPanel.test.tsx
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

bito-code-review · 2026-05-07T08:27:52Z

Code Review Agent Run #ecdba7

Actionable Suggestions - 0

Review Details

Files reviewed - 1 · Commit Range: deec9f4..055312b
- superset-frontend/plugins/plugin-chart-ag-grid-table/test/controlPanel.test.tsx
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

rusackas · 2026-05-12T20:19:00Z

Looks like this needs a rebase. No word from @amaannawab923 - should we merge this when rebased, @msyavuz ?

amaannawab923 · 2026-05-12T20:45:28Z

Sorry for the delay, @rusackas. The filterable filter in mapStateToProps is legacy from pre-monorepo days (back when chart plugins lived in their own superset-ui repo) it incorrectly conflated "filterable" with "usable as a metric/dimension." AG Grid likely inherited it because it was built on top of the Table plugin.

Fix is correct , LGTM to merge once rebased.

cc: @msyavuz

…columns-metric-display # Conflicts: # superset-frontend/plugins/plugin-chart-table/test/controlPanel.test.tsx

bito-code-review · 2026-05-23T23:47:15Z

Bito Automatic Review Failed - Technical Failure

Bito encountered technical difficulties while generating code feedback . To retry, type /review in a comment and save. If the issue persists, contact support@bito.ai and provide the following details:

Agent Run ID: d0140847-151b-4ec0-a2d5-c37b0b49403b

pull-request-size Bot added the size/S label Apr 21, 2026

dosubot Bot added change:frontend Requires changing the frontend plugins labels Apr 21, 2026

codeant-ai-for-open-source Bot reviewed Apr 21, 2026

View reviewed changes

Comment thread superset-frontend/plugins/plugin-chart-ag-grid-table/src/controlPanel.tsx Outdated

Comment thread superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx Outdated

fix(charts): show non-filterable columns in metric section for table …

d0a3fbc

…charts

massucattoj force-pushed the fix/non-filterable-columns-metric-display branch from 5dd1d49 to d0a3fbc Compare April 21, 2026 15:01

Merge branch 'master' into fix/non-filterable-columns-metric-display

50c6fc8

msyavuz reviewed Apr 27, 2026

View reviewed changes

test: add unit tests

4c08254

pull-request-size Bot added size/L and removed size/S labels May 4, 2026

Merge branch 'master' into fix/non-filterable-columns-metric-display

deec9f4

massucattoj added 2 commits May 6, 2026 20:04

Merge branch 'master' into fix/non-filterable-columns-metric-display

56d542d

chore: apply prettier formatting

055312b

sadpandajoe requested a review from amaannawab923 May 18, 2026 16:57

Merge remote-tracking branch 'origin/master' into fix/non-filterable-…

2971c52

…columns-metric-display # Conflicts: # superset-frontend/plugins/plugin-chart-table/test/controlPanel.test.tsx

massucattoj requested a review from msyavuz May 23, 2026 16:46

Merge branch 'master' into fix/non-filterable-columns-metric-display

95ee854

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(charts): show non-filterable columns in metric section for table …#39524

fix(charts): show non-filterable columns in metric section for table …#39524
massucattoj wants to merge 8 commits into
apache:masterfrom
massucattoj:fix/non-filterable-columns-metric-display

massucattoj commented Apr 21, 2026

Uh oh!

bito-code-review Bot commented Apr 21, 2026 •

edited

Loading

Code Review Agent Run #fcce81

Uh oh!

Uh oh!

Uh oh!

bito-code-review Bot commented Apr 21, 2026 •

edited

Loading

Code Review Agent Run #fd2c1a

Uh oh!

codecov Bot commented Apr 26, 2026 •

edited

Loading

Uh oh!

msyavuz left a comment

Uh oh!

bito-code-review Bot commented May 4, 2026 •

edited

Loading

Code Review Agent Run #e3b9ca

Uh oh!

bito-code-review Bot commented May 7, 2026 •

edited

Loading

Code Review Agent Run #ecdba7

Uh oh!

rusackas commented May 12, 2026

Uh oh!

amaannawab923 commented May 12, 2026 •

edited

Loading

Uh oh!

bito-code-review Bot commented May 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

massucattoj commented Apr 21, 2026

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Uh oh!

bito-code-review Bot commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #fcce81

Uh oh!

Uh oh!

Uh oh!

bito-code-review Bot commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #fd2c1a

Uh oh!

codecov Bot commented Apr 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

msyavuz left a comment

Choose a reason for hiding this comment

Uh oh!

bito-code-review Bot commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #e3b9ca

Uh oh!

bito-code-review Bot commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #ecdba7

Uh oh!

rusackas commented May 12, 2026

Uh oh!

amaannawab923 commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bito-code-review Bot commented May 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bito-code-review Bot commented Apr 21, 2026 •

edited

Loading

bito-code-review Bot commented Apr 21, 2026 •

edited

Loading

codecov Bot commented Apr 26, 2026 •

edited

Loading

bito-code-review Bot commented May 4, 2026 •

edited

Loading

bito-code-review Bot commented May 7, 2026 •

edited

Loading

amaannawab923 commented May 12, 2026 •

edited

Loading