fix(docker): add missing service-worker.js into built container image

[hainenber]

fix(docker): add missing service-worker.js into built container image

SUMMARY

Fixes #39431

Add a COPY clause to copy missing service-worker.js into built container image, namely lean.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[bito-code-review]

Code Review Agent Run #f2624e

Actionable Suggestions - 0

Review Details

• Files reviewed - 1 · Commit Range: 3d16776..3d16776

  • Dockerfile
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[bito-code-review]

The flagged issue is valid — the COPY command at line 205 in Dockerfile will fail when DEV_MODE=true because the superset-node stage skips npm run build, leaving /app/superset/static/service-worker.js uncreated. To resolve, ensure the file is always generated in the node stage. Fix: Modify the superset-node stage to always execute npm run ${BUILD_CMD}, even in dev mode. There are no other comments on this PR.

Dockerfile

RUN npm run ${BUILD_CMD}

[bito-code-review]

Code Review Agent Run #651bb5

Actionable Suggestions - 0

Review Details

• Files reviewed - 1 · Commit Range: 3d16776..fce5e35

  • Dockerfile
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by