chore(ci): trim off duplicated deps using npm dedupe#39659
Closed
hainenber wants to merge 3 commits into
Closed
Conversation
Signed-off-by: hainenber <dotronghai96@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #39659 +/- ##
==========================================
+ Coverage 64.14% 64.76% +0.61%
==========================================
Files 2590 2572 -18
Lines 138084 135299 -2785
Branches 32037 31652 -385
==========================================
- Hits 88577 87621 -956
+ Misses 47986 46183 -1803
+ Partials 1521 1495 -26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
That is a MASSIVE lockfile change. And presumably a nasty conflict. If you wanna try again, ping me when it's green, and we can try to slam it through more expediently this time :D |
Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
Contributor
Author
|
Closing this off as post-React18 dedupe actually increases dep bloats. I'll find other areas. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chore(ci): trim off duplicated deps using
npm dedupeSUMMARY
Chore PR that runs
npm dedupeto get a low-hanging fruit on dep bloats (69 deps trimmed) and reduce possible attack surfaceBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
Green CI as acceptance threshold
ADDITIONAL INFORMATION