Skip to content

chore(ci): trim off duplicated deps using npm dedupe#39659

Closed
hainenber wants to merge 3 commits into
masterfrom
chore/run-npm-dedupe
Closed

chore(ci): trim off duplicated deps using npm dedupe#39659
hainenber wants to merge 3 commits into
masterfrom
chore/run-npm-dedupe

Conversation

@hainenber
Copy link
Copy Markdown
Contributor

@hainenber hainenber commented Apr 26, 2026

chore(ci): trim off duplicated deps using npm dedupe

SUMMARY

Chore PR that runs npm dedupe to get a low-hanging fruit on dep bloats (69 deps trimmed) and reduce possible attack surface

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

Green CI as acceptance threshold

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Signed-off-by: hainenber <dotronghai96@gmail.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.76%. Comparing base (64dae07) to head (2dfaad1).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #39659      +/-   ##
==========================================
+ Coverage   64.14%   64.76%   +0.61%     
==========================================
  Files        2590     2572      -18     
  Lines      138084   135299    -2785     
  Branches    32037    31652     -385     
==========================================
- Hits        88577    87621     -956     
+ Misses      47986    46183    -1803     
+ Partials     1521     1495      -26     
Flag Coverage Δ
javascript 67.01% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hainenber hainenber marked this pull request as ready for review April 26, 2026 12:52
@rusackas
Copy link
Copy Markdown
Member

That is a MASSIVE lockfile change. And presumably a nasty conflict. If you wanna try again, ping me when it's green, and we can try to slam it through more expediently this time :D

@sadpandajoe sadpandajoe requested a review from rusackas May 13, 2026 17:18
hainenber added 2 commits May 14, 2026 22:07
Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber
Copy link
Copy Markdown
Contributor Author

Closing this off as post-React18 dedupe actually increases dep bloats. I'll find other areas.

@hainenber hainenber closed this May 14, 2026
@hainenber hainenber deleted the chore/run-npm-dedupe branch May 15, 2026 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants