fix(dev): revert `react-checkbox-tree` from 2.1.0 to 1.8.0 in /superset-frontend by hainenber · Pull Request #39660 · apache/superset

hainenber · 2026-04-26T11:53:14Z

…/superse…" This reverts commit f672b14.

bito-code-review · 2026-04-26T11:53:24Z

Bito Review Skipped - No Changes Detected

Bito didn't review this pull request because we did not detect any changes in the pull request to review.

rusackas · 2026-04-27T06:32:56Z

Weird... 0 changed files?

hainenber · 2026-04-27T06:34:24Z

Not weird at all. It's me hitting the Revert button without checking 🤦

…ntion rule Signed-off-by: hainenber <dotronghai96@gmail.com>

…ange react-checkbox-tree 2.0.0 changed the clickable node label from role="link" to role="button" (the rct-node-clickable span). The FilterScope test suite queried these nodes via getByRole('link'), which caused 9 failures in sharded-jest-tests (2). Updated superset-frontend/src/dashboard/components/filterscope/FilterScope.test.tsx to query role 'button' instead of 'link' in getCheckboxState, clickCheckbox, and the assertions on filter/chart/tab tree nodes. Real button queries (Close, Save, Collapse/Expand all) were already role 'button' and are unchanged.

Signed-off-by: hainenber <dotronghai96@gmail.com>

…set-frontend/react-checkbox-tree-2.0.0

codecov · 2026-04-27T08:11:02Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.48%. Comparing base (a216b23) to head (f9c564f).

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #39660   +/-   ##
=======================================
  Coverage   64.48%   64.48%           
=======================================
  Files        2566     2566           
  Lines      133926   133926           
  Branches    31096    31096           
=======================================
  Hits        86357    86357           
  Misses      46074    46074           
  Partials     1495     1495

Flag	Coverage Δ
javascript	`66.55% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

bito-code-review · 2026-04-27T08:45:45Z

Code Review Agent Run #b99e58

Actionable Suggestions - 0

Review Details

Files reviewed - 1 · Commit Range: ef0a026..f9c564f
- superset-frontend/src/dashboard/components/filterscope/FilterScope.test.tsx
Files skipped - 3
- .github/dependabot.yml - Reason: Filter setting
- superset-frontend/package-lock.json - Reason: Filter setting
- superset-frontend/package.json - Reason: Filter setting
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

msyavuz

I was looking to see if anyone else has a pr to fix this, thank you!

bito-code-review · 2026-04-27T16:02:29Z

Yes, this change appears intentional. The downgrade of react-checkbox-tree from 2.0.1 to 1.8.0 likely altered the component's role from 'button' to 'link', requiring the test assertions to be updated accordingly.

hainenber · 2026-04-27T16:12:17Z

Oops, I didnt request Mehmet's approval yet so his wasnt counted. @msyavuz can you re-approve? Thanks!

msyavuz · 2026-04-27T16:14:03Z

I think we still need a code owner stamp

hainenber · 2026-04-27T16:15:22Z

Yep, that should work. @rusackas can you help approving this? Thanks!

rusackas

Thanks @hainenber — LGTM.

* fix(docs): fix 404s in documentation (apache#38974) Co-authored-by: Evan Rusackas <evan@preset.io> * chore(deps): bump baseline-browser-mapping from 2.10.21 to 2.10.23 in /docs (apache#39671) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump d3-cloud from 1.2.8 to 1.2.9 in /superset-frontend (apache#39677) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(ci): update Node.js version used in building CI image (apache#38635) * fix(explore): ensure unsaved-changes dialog renders above View SQL modal (apache#39569) Co-authored-by: yousoph <sophieyou12@gmail.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(Modal): prevent title overlapping with close button in long header titles (apache#36536) * fix(mcp): database filter columns, timeseries SQL, and unsaved chart datasource name (apache#39636) * docs(rls): adding additional rls filter documentation (apache#38829) Co-authored-by: codeant-ai-for-open-source[bot] <244253245+codeant-ai-for-open-source[bot]@users.noreply.github.com> * fix(dev): revert `react-checkbox-tree` from 2.1.0 to 1.8.0 in /superset-frontend (apache#39660) Signed-off-by: hainenber <dotronghai96@gmail.com> Co-authored-by: Evan Rusackas <evan@rusackas.com> * chore(deps-dev): bump typescript-eslint from 8.59.0 to 8.59.1 in /superset-websocket (apache#39687) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(plugin-chart-handlebars): preserve template on explore open (apache#39442) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(mcp): surface structured errors for generate_chart validation failures (apache#39484) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(table chart): fix rerender bug that continuously cleared search box (apache#39707) * fix(query-history): enable sorting by Duration column (apache#39637) Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(security): add generic validation for guest token API (closes #8) Co-Authored-By: Chiranjeevi Balawat <cbalawat@gmail.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: hainenber <dotronghai96@gmail.com> Co-authored-by: David <39565245+dmunozv04@users.noreply.github.com> Co-authored-by: Evan Rusackas <evan@preset.io> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Đỗ Trọng Hải <41283691+hainenber@users.noreply.github.com> Co-authored-by: yousoph <sophieyou12@gmail.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: innovark <eric.graham@mailfence.com> Co-authored-by: Amin Ghadersohi <amin.ghadersohi@gmail.com> Co-authored-by: SkinnyPigeon <e.blackledge@stuart.com> Co-authored-by: codeant-ai-for-open-source[bot] <244253245+codeant-ai-for-open-source[bot]@users.noreply.github.com> Co-authored-by: Evan Rusackas <evan@rusackas.com> Co-authored-by: Mehmet Salih Yavuz <salih.yavuz@proton.me> Co-authored-by: Sam Firke <sfirke@users.noreply.github.com> Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: Chiranjeevi Balawat <cbalawat@gmail.com>

Revert "chore(deps): bump react-checkbox-tree from 1.8.0 to 2.0.1 in …

4193180

…/superse…" This reverts commit f672b14.

pull-request-size Bot added the size/XS label Apr 26, 2026

dosubot Bot added the dependencies:npm label Apr 26, 2026

hainenber changed the title ~~Revert "chore(deps): bump react-checkbox-tree from 1.8.0 to 2.0.1 in /superset-frontend"~~ fix(dev): revert react-checkbox-tree from 2.1.0 to 1.8.0 in /superset-frontend Apr 26, 2026

hainenber changed the title ~~fix(dev): revert react-checkbox-tree from 2.1.0 to 1.8.0 in /superset-frontend~~ fix(dev): revert react-checkbox-tree from 2.1.0 to 1.8.0 in /superset-frontend Apr 26, 2026

hainenber requested a review from rusackas April 26, 2026 14:47

fix(build): revert react-checkbox-tree to v1 + add Dependabot preve…

8188aa6

…ntion rule Signed-off-by: hainenber <dotronghai96@gmail.com>

hainenber requested review from betodealmeida, craig-rueda, dpgaspar, eschutho, geido, kgabryje, mistercrunch, nytai, sadpandajoe and villebro as code owners April 27, 2026 06:38

rusackas and others added 2 commits April 27, 2026 14:26

chore: adapt FilterScope tets to react-checkbox-tree v1

76b452d

Signed-off-by: hainenber <dotronghai96@gmail.com>

hainenber force-pushed the revert-39261-dependabot/npm_and_yarn/superset-frontend/react-checkbox-tree-2.0.0 branch from 28eddf0 to 76b452d Compare April 27, 2026 07:42

pull-request-size Bot added size/M and removed size/XS labels Apr 27, 2026

Merge branch 'master' into revert-39261-dependabot/npm_and_yarn/super…

f9c564f

…set-frontend/react-checkbox-tree-2.0.0

msyavuz reviewed Apr 27, 2026

View reviewed changes

Comment thread superset-frontend/src/dashboard/components/filterscope/FilterScope.test.tsx

msyavuz approved these changes Apr 27, 2026

View reviewed changes

hainenber requested a review from msyavuz April 27, 2026 16:10

msyavuz approved these changes Apr 27, 2026

View reviewed changes

EnxDev approved these changes Apr 27, 2026

View reviewed changes

rusackas approved these changes Apr 27, 2026

View reviewed changes

rusackas merged commit 5fe3a1c into master Apr 27, 2026
72 checks passed

rusackas deleted the revert-39261-dependabot/npm_and_yarn/superset-frontend/react-checkbox-tree-2.0.0 branch April 27, 2026 18:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(dev): revert `react-checkbox-tree` from 2.1.0 to 1.8.0 in /superset-frontend#39660

fix(dev): revert `react-checkbox-tree` from 2.1.0 to 1.8.0 in /superset-frontend#39660
rusackas merged 5 commits intomasterfrom
revert-39261-dependabot/npm_and_yarn/superset-frontend/react-checkbox-tree-2.0.0

hainenber commented Apr 26, 2026

Uh oh!

bito-code-review Bot commented Apr 26, 2026 •

edited

Loading

Uh oh!

rusackas commented Apr 27, 2026

Uh oh!

hainenber commented Apr 27, 2026

Uh oh!

codecov Bot commented Apr 27, 2026

Uh oh!

bito-code-review Bot commented Apr 27, 2026 •

edited

Loading

Code Review Agent Run #b99e58

Uh oh!

msyavuz left a comment

Uh oh!

Uh oh!

bito-code-review Bot commented Apr 27, 2026

Uh oh!

hainenber commented Apr 27, 2026

Uh oh!

msyavuz commented Apr 27, 2026

Uh oh!

hainenber commented Apr 27, 2026

Uh oh!

rusackas left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

hainenber commented Apr 26, 2026

Uh oh!

bito-code-review Bot commented Apr 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rusackas commented Apr 27, 2026

Uh oh!

hainenber commented Apr 27, 2026

Uh oh!

codecov Bot commented Apr 27, 2026

Codecov Report

Uh oh!

bito-code-review Bot commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #b99e58

Uh oh!

msyavuz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bito-code-review Bot commented Apr 27, 2026

Uh oh!

hainenber commented Apr 27, 2026

Uh oh!

msyavuz commented Apr 27, 2026

Uh oh!

hainenber commented Apr 27, 2026

Uh oh!

rusackas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bito-code-review Bot commented Apr 26, 2026 •

edited

Loading

bito-code-review Bot commented Apr 27, 2026 •

edited

Loading