Skip to content

fix(ci): trigger python dep check when pyproject.toml changes#39792

Open
sadpandajoe wants to merge 2 commits into
masterfrom
investigate-deps-ci-break
Open

fix(ci): trigger python dep check when pyproject.toml changes#39792
sadpandajoe wants to merge 2 commits into
masterfrom
investigate-deps-ci-break

Conversation

@sadpandajoe
Copy link
Copy Markdown
Member

SUMMARY

The check-python-deps CI job was silently skipping the uv-pip-compile step for any commit that only touched pyproject.toml (e.g. Dependabot dependency bumps). This meant requirements/ files could drift out of sync with pyproject.toml without CI catching it.

Root cause: scripts/change_detector.py lists file patterns that trigger the python output flag, but pyproject.toml was not in the list. When Dependabot merged PR #39749 (psycopg2-binary 2.9.9 → 2.9.12), it only modified pyproject.toml, so change_detector returned python=false, the uv step was skipped, and the mismatch entered master undetected. The CI then started failing on the next unrelated Python-touching commit.

Fix: add pyproject.toml to the python patterns so bumps to it always trigger the uv recompile check.

Also fixes a pre-existing S603 noqa placement on line 155 of change_detector.py that was already failing ruff 0.4.0.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

  1. Open a PR that only modifies pyproject.toml (e.g. bump a Python dep version)
  2. Verify the check-python-deps job now runs the Run uv and Check for uncommitted changes steps
  3. If requirements/ was not regenerated, the job should fail with the "pinned dependencies are not up-to-date" error

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration
  • Introduces new feature or API
  • Removes existing feature or API

Dependabot bumps to pyproject.toml were silently skipping the
uv-pip-compile step because pyproject.toml was not in the change
detector's python pattern list. This meant requirements/ files could
drift out of sync without CI catching it.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@bito-code-review
Copy link
Copy Markdown
Contributor

bito-code-review Bot commented Apr 30, 2026

Code Review Agent Run #577777

Actionable Suggestions - 0
Review Details
  • Files reviewed - 1 · Commit Range: 2916c7e..2916c7e
    • scripts/change_detector.py
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • MyPy (Static Code Analysis) - ✔︎ Successful
    • Astral Ruff (Static Code Analysis) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@github-actions github-actions Bot added the risk:ci-script PR modifies scripts that execute in CI (supply chain risk) label Apr 30, 2026
@dosubot dosubot Bot added dependencies:python github_actions Pull requests that update GitHub Actions code labels Apr 30, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.88%. Comparing base (105820f) to head (80b9157).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #39792      +/-   ##
==========================================
- Coverage   64.19%   63.88%   -0.31%     
==========================================
  Files        2591     2585       -6     
  Lines      138392   136964    -1428     
  Branches    32109    31533     -576     
==========================================
- Hits        88837    87497    -1340     
+ Misses      48025    47937      -88     
  Partials     1530     1530              
Flag Coverage Δ
hive 39.41% <ø> (ø)
mysql 59.08% <ø> (ø)
postgres 59.16% <ø> (ø)
presto 41.10% <ø> (ø)
python 60.59% <ø> (ø)
sqlite 58.79% <ø> (ø)
unit 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rusackas rusackas added the merge-if-green If approved and tests are green, please go ahead and merge it for me label May 20, 2026
@github-actions github-actions Bot removed github_actions Pull requests that update GitHub Actions code dependencies:python labels May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-if-green If approved and tests are green, please go ahead and merge it for me risk:ci-script PR modifies scripts that execute in CI (supply chain risk) size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants