fix(ci): trigger python dep check when pyproject.toml changes#39792
fix(ci): trigger python dep check when pyproject.toml changes#39792sadpandajoe wants to merge 2 commits into
Conversation
Dependabot bumps to pyproject.toml were silently skipping the uv-pip-compile step because pyproject.toml was not in the change detector's python pattern list. This meant requirements/ files could drift out of sync without CI catching it. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Code Review Agent Run #577777Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #39792 +/- ##
==========================================
- Coverage 64.19% 63.88% -0.31%
==========================================
Files 2591 2585 -6
Lines 138392 136964 -1428
Branches 32109 31533 -576
==========================================
- Hits 88837 87497 -1340
+ Misses 48025 47937 -88
Partials 1530 1530
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SUMMARY
The
check-python-depsCI job was silently skipping theuv-pip-compilestep for any commit that only touchedpyproject.toml(e.g. Dependabot dependency bumps). This meantrequirements/files could drift out of sync withpyproject.tomlwithout CI catching it.Root cause:
scripts/change_detector.pylists file patterns that trigger thepythonoutput flag, butpyproject.tomlwas not in the list. When Dependabot merged PR #39749 (psycopg2-binary 2.9.9 → 2.9.12), it only modifiedpyproject.toml, sochange_detectorreturnedpython=false, the uv step was skipped, and the mismatch entered master undetected. The CI then started failing on the next unrelated Python-touching commit.Fix: add
pyproject.tomlto the python patterns so bumps to it always trigger the uv recompile check.Also fixes a pre-existing
S603noqa placement on line 155 ofchange_detector.pythat was already failing ruff 0.4.0.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
pyproject.toml(e.g. bump a Python dep version)check-python-depsjob now runs theRun uvandCheck for uncommitted changesstepsrequirements/was not regenerated, the job should fail with the "pinned dependencies are not up-to-date" errorADDITIONAL INFORMATION