fix(ux): use title case for button labels

[aminghadersohi]

SUMMARY

Replaces ALL CAPS button labels with Title Case to align with the Superset design system convention. Six labels across five files were using uppercase strings that violate the established button label style.

Changes:

• DateFilterLabel.tsx: CANCEL → Cancel, APPLY → Apply
• AnnotationLayer.tsx: OK → Confirm
• DatasourceModal/index.tsx: OK → Confirm
• Tabs.tsx: DELETE → Delete
• ResultSet/index.tsx: OK → Confirm

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before: Button labels displayed in ALL CAPS (e.g. CANCEL, APPLY, OK, DELETE)
After: Button labels displayed in Title Case (e.g. Cancel, Apply, Confirm, Delete)

TESTING INSTRUCTIONS

1. Open the Date Filter control → verify Cancel and Apply buttons are title case
2. Open an Annotation Layer → verify the submit button shows "Confirm"
3. Open a Datasource modal and trigger the confirm save dialog → verify "Confirm" button
4. On a dashboard with tabs, delete a tab → verify the danger button shows "Delete"
5. In SQL Lab, run a large query and export → verify the confirmation dialog shows "Confirm"

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
• Introduces new feature or API
• Removes existing feature or API

[bito-code-review]

Code Review Agent Run #ee6107

Actionable Suggestions - 1

• superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx - 1

  • Test expectation mismatch · Line 331-331

Review Details

• Files reviewed - 5 · Commit Range: 0b89968..0b89968

  • superset-frontend/src/SqlLab/components/ResultSet/index.tsx
  • superset-frontend/src/components/Datasource/DatasourceModal/index.tsx
  • superset-frontend/src/dashboard/components/gridComponents/Tabs/Tabs.tsx
  • superset-frontend/src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.tsx
  • superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[bito-code-review]

Test expectation mismatch

Update DateFilterLabel.test.tsx to expect 'Cancel' instead of 'CANCEL' and 'Apply' instead of 'APPLY' in the popover tests.

Code Review Run #ee6107

---

Should Bito avoid suggestions like this for future reviews? (Manage Rules)

• Yes, avoid them

[kasiazjc]

Closing to reopen under the correct author (kasiazjc).