Skip to content

chore(gha): pin github/codeql-action to a SHA#40043

Merged
rusackas merged 1 commit into
masterfrom
chore/pin-codeql-action-sha
May 12, 2026
Merged

chore(gha): pin github/codeql-action to a SHA#40043
rusackas merged 1 commit into
masterfrom
chore/pin-codeql-action-sha

Conversation

@rusackas
Copy link
Copy Markdown
Member

SUMMARY

Pin both `github/codeql-action/init@v4` and `github/codeql-action/analyze@v4` in `.github/workflows/codeql-analysis.yml` to the commit SHA the `v4` tag currently dereferences to:

```yaml
uses: github/codeql-action@68bde55 # v4
```

`# v4` is kept as a trailing comment for readability and matches the existing convention for `actions/checkout` on line 34 of the same file.

This is the standard mitigation for the supply-chain risk of mutable tags (a tag can be force-pushed by an attacker who compromises the upstream repo; a SHA cannot). Verified that `refs/tags/v4` on `github/codeql-action` dereferences to `68bde559dea0fdcac2102bfdf6230c5f70eb485e` at the time of this PR.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A — workflow change only.

TESTING INSTRUCTIONS

GitHub Actions workflow files aren't unit-testable in this repo's test suite. Verifiable by inspection: both `uses:` lines now reference a 40-char SHA followed by `# v4`, matching the `actions/checkout` line above them.

CodeQL analysis behavior is unchanged — the action source code at the pinned SHA is byte-identical to what `@v4` resolved to on the previous run.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
  • Introduces new feature or API
  • Removes existing feature or API

Replace `github/codeql-action/init@v4` and
`github/codeql-action/analyze@v4` with the commit SHA the v4 tag
currently dereferences to (68bde559dea0fdcac2102bfdf6230c5f70eb485e),
keeping `# v4` as a trailing comment for readability.

This matches the existing convention for actions/checkout on line 34
of the same file and is the standard mitigation for the supply-chain
risk of mutable tags.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@bito-code-review
Copy link
Copy Markdown
Contributor

bito-code-review Bot commented May 12, 2026

Bito Automatic Review Skipped - Files Excluded

Bito didn't auto-review this change because all changed files are in the exclusion list for automatic reviews. No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the excluded files settings here, or contact your Bito workspace admin at evan@preset.io.

@github-actions github-actions Bot added the github_actions Pull requests that update GitHub Actions code label May 12, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented May 12, 2026

Deploy Preview for superset-docs-preview ready!

Name Link
🔨 Latest commit cfbfe43
🔍 Latest deploy log https://app.netlify.com/projects/superset-docs-preview/deploys/6a02977a848c7d00088f2657
😎 Deploy Preview https://deploy-preview-40043--superset-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@rusackas rusackas merged commit 5ab8583 into master May 12, 2026
62 of 66 checks passed
@rusackas rusackas deleted the chore/pin-codeql-action-sha branch May 12, 2026 03:18
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
Co-authored-by: Superset Dev <dev@superset.apache.org>
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants