test(datasets): regression coverage for #16141 (export with same table name, different schemas)

[rusackas]

SUMMARY

TDD-first regression coverage for #16141 (Aug 2021): exporting two datasets with the same table_name but different schemas (e.g. prod.users + dev.users) historically returned only one file because the export filename did not disambiguate the pair.

The current ExportDatasetsCommand already produces <table_name>_<id>.yaml, so the original collision should no longer occur — but no test pinned the behavior, leaving the bug technically open and at risk of silent regression.

This PR is a small experiment in a test-PR-first workflow: open a failing-or-passing test that encodes the bug's contract before doing any code changes. If CI passes, the bug is provably fixed and #16141 can close. If CI fails, the test documents exactly what still needs work for whoever picks up the fix.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A — test-only.

TESTING INSTRUCTIONS

pytest tests/unit_tests/datasets/commands/export_test.py::test_export_two_datasets_same_table_name_different_schema -xvs

The test creates two SqlaTable rows with identical table_name="users" and distinct schemas (prod, dev), runs ExportDatasetsCommand._export on each, and asserts:

1. The two emitted file paths are distinct (no filename collision).
2. Both emitted YAML payloads carry the correct schema: field — neither is silently overwritten.

ADDITIONAL INFORMATION

• Has associated issue: Closes API: Export: Exporting 2 physical datasets with the same table name but different schema returns only 1 dataset #16141
• Required feature flags:
• Changes UI
• Includes DB Migration
• Introduces new feature or API
• Removes existing feature or API

[bito-code-review]

Code Review Agent Run #3d5e37

Actionable Suggestions - 0

Review Details

• Files reviewed - 1 · Commit Range: 233eb49..233eb49

  • tests/unit_tests/datasets/commands/export_test.py
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful
  • MyPy (Static Code Analysis) - ✔︎ Successful
  • Astral Ruff (Static Code Analysis) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.16%. Comparing base (62dc237) to head (3587a72).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #40123      +/-   ##
==========================================
+ Coverage   64.15%   64.16%   +0.01%     
==========================================
  Files        2590     2590              
  Lines      138104   138087      -17     
  Branches    32039    32039              
==========================================
+ Hits        88599    88608       +9     
+ Misses      47984    47954      -30     
- Partials     1521     1525       +4     

Flag	Coverage Δ
hive	39.47% <ø> (+0.03%)	⬆️
mysql	59.17% <ø> (+0.04%)	⬆️
postgres	59.25% <ø> (+0.04%)	⬆️
presto	41.16% <ø> (+0.03%)	⬆️
python	60.69% <ø> (+0.04%)	⬆️
sqlite	58.89% <ø> (+0.04%)	⬆️
unit	100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Pull request overview

This PR adds a regression test for issue #16141, which previously caused dataset exports to collide when two datasets shared a table_name but had different schemas. The current ExportDatasetsCommand filenames already include the dataset id (<table_name>_<id>.yaml), so the test should now pass and pin the fix.

Changes:

• Adds a single unit test that creates two SqlaTable rows with identical table_name but distinct schemas and verifies the exports produce distinct paths and preserve each schema in the YAML payload.

[sadpandajoe]

Left one question but not blocking so approving.

[bito-code-review]

Yes, using yaml.safe_load would be a more robust alternative to string splitting for parsing the YAML content, as it properly handles the structure and avoids potential errors from manual splitting. However, since the current approach works for this test's specific needs and isn't causing issues, it's not urgent to change.

tests/unit_tests/datasets/commands/export_test.py

import yaml

# Alternative parsing
schemas_in_yaml = {yaml.safe_load(c)['schema'] for c in contents}

[bito-code-review]

Bito Automatic Review Skipped – PR Already Merged

Bito scheduled an automatic review for this pull request, but the review was skipped because this PR was merged before the review could be run.
No action is needed if you didn't intend to review it. To get a review, you can type /review in a comment and save it