Skip to content

fix(UserListModal): Success notification mentions user and not group#40284

Merged
SBIN2010 merged 1 commit into
apache:masterfrom
xavier-GitHub76:fix(UserListModal)--success-toast-user
May 24, 2026
Merged

fix(UserListModal): Success notification mentions user and not group#40284
SBIN2010 merged 1 commit into
apache:masterfrom
xavier-GitHub76:fix(UserListModal)--success-toast-user

Conversation

@xavier-GitHub76
Copy link
Copy Markdown
Contributor

@xavier-GitHub76 xavier-GitHub76 commented May 20, 2026

Simple fix for a wrong notification (fixes #40244)

"group" is replaced by "user"

@dosubot dosubot Bot added change:frontend Requires changing the frontend global:users Related to users and roles labels May 20, 2026
@bito-code-review
Copy link
Copy Markdown
Contributor

bito-code-review Bot commented May 20, 2026

Code Review Agent Run #9e96d8

Actionable Suggestions - 0
Review Details
  • Files reviewed - 1 · Commit Range: a8bbc23..a8bbc23
    • superset-frontend/src/features/users/UserListModal.tsx
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 64.16%. Comparing base (e617903) to head (a8bbc23).
⚠️ Report is 21 commits behind head on master.

Files with missing lines Patch % Lines
...rset-frontend/src/features/users/UserListModal.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #40284   +/-   ##
=======================================
  Coverage   64.16%   64.16%           
=======================================
  Files        2591     2591           
  Lines      138293   138293           
  Branches    32084    32084           
=======================================
  Hits        88736    88736           
  Misses      48027    48027           
  Partials     1530     1530           
Flag Coverage Δ
javascript 67.04% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@sadpandajoe sadpandajoe added the merge-if-green If approved and tests are green, please go ahead and merge it for me label May 20, 2026
@SBIN2010 SBIN2010 changed the title fix(UserListModal) : Success notification mentions user and not group fix(UserListModal): Success notification mentions user and not group May 24, 2026
@SBIN2010 SBIN2010 merged commit fe484f6 into apache:master May 24, 2026
79 of 83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change:frontend Requires changing the frontend global:users Related to users and roles merge-if-green If approved and tests are green, please go ahead and merge it for me size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add user (without group) -> Message "The group has been created"

4 participants