chore(docker): remove debugger flag from Flask dev server startup#40298
chore(docker): remove debugger flag from Flask dev server startup#40298sha174n wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
![codeant-ai-for-open-source[bot]](https://avatars.githubusercontent.com/u/151810221?s=60&v=4){kind=small}
| app) | ||
| echo "Starting web app (using development server)..." | ||
| flask run -p $PORT --reload --debugger --host=0.0.0.0 --exclude-patterns "*/node_modules/*:*/.venv/*:*/build/*:*/__pycache__/*:*/superset-frontend/*" | ||
| flask run -p $PORT --reload --host=0.0.0.0 --exclude-patterns "*/node_modules/*:*/.venv/*:*/build/*:*/__pycache__/*:*/superset-frontend/*" |
There was a problem hiding this comment.
🟠 Architect Review — HIGH
Removing only the --debugger flag from the Docker dev flask run command does not disable the Werkzeug debugger, because the superset container still runs with FLASK_DEBUG=true from docker/.env via docker-compose.yml, and Flask debug mode enables the debugger (and its console) by default.
Suggestion: Explicitly disable the debugger for Docker app startup, for example by passing --no-debugger to flask run or updating the Docker dev environment so it does not set FLASK_DEBUG=true while preserving reload behavior, aligning this with docker/.env and the env_file configuration in docker-compose.yml.
Fix in Cursor | Fix in VSCode Claude
(Use Cmd/Ctrl + Click for best experience)
Prompt for AI Agent 🤖
This is an **Architect / Logical Review** comment left during a code review. These reviews are first-class, important findings — not optional suggestions. Do NOT dismiss this as a 'big architectural change' just because the title says architect review; most of these can be resolved with a small, localized fix once the intent is understood.
**Path:** docker/docker-bootstrap.sh
**Line:** 83:83
**Comment:**
*HIGH: Removing only the `--debugger` flag from the Docker dev `flask run` command does not disable the Werkzeug debugger, because the superset container still runs with `FLASK_DEBUG=true` from `docker/.env` via `docker-compose.yml`, and Flask debug mode enables the debugger (and its console) by default.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
If a suggested approach is provided above, use it as the authoritative instruction. If no explicit code suggestion is given, you MUST still draft and apply your own minimal, localized fix — do not punt back with 'no suggestion provided, review manually'. Keep the change as small as possible: add a guard clause, gate on a loading state, reorder an await, wrap in a conditional, etc. Do not refactor surrounding code or expand scope beyond the finding.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
|
The provided |
![bito-code-review[bot]](https://avatars.githubusercontent.com/in/1061978?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review Agent Run #633284
Actionable Suggestions - 1
-
docker/docker-bootstrap.sh - 1
- Documentation Inconsistency · Line 83-83
Additional Suggestions - 1
-
docker/docker-bootstrap.sh - 1
-
Missing Debugger Flag Context · Line 83-83Removing --debugger disables Werkzeug's interactive debugger, which provides interactive traceback inspection. While --debug enables reloading and error pages, the interactive debugger offers additional debugging capabilities. Consider documenting this trade-off or adding a comment explaining the intentional removal.
-
Review Details
-
Files reviewed - 1 · Commit Range:
c50468f..c50468f- docker/docker-bootstrap.sh
-
Files skipped - 0
-
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
Bito Usage Guide
Commands
Type the following command in the pull request comment and save the comment.
-
/review- Manually triggers a full AI review. -
/pause- Pauses automatic reviews on this pull request. -
/resume- Resumes automatic reviews. -
/resolve- Marks all Bito-posted review comments as resolved. -
/abort- Cancels all in-progress reviews.
Refer to the documentation for additional commands.
Configuration
This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.
Documentation & Help
AI Code Review powered by
| app) | ||
| echo "Starting web app (using development server)..." | ||
| flask run -p $PORT --reload --debugger --host=0.0.0.0 --exclude-patterns "*/node_modules/*:*/.venv/*:*/build/*:*/__pycache__/*:*/superset-frontend/*" | ||
| flask run -p $PORT --reload --host=0.0.0.0 --exclude-patterns "*/node_modules/*:*/.venv/*:*/build/*:*/__pycache__/*:*/superset-frontend/*" |
There was a problem hiding this comment.
Documentation in docs/developer_docs/contributing/development-setup.md (lines 410, 434, 588, 843, 908-909) and docs/developer_docs_versioned_docs/version-6.1.0/contributing/development-setup.md still reference --debugger flag that this change removes. Documentation must accurately reflect implemented code per BITO.md rule 10906.
Code Review Run #633284
Should Bito avoid suggestions like this for future reviews? (Manage Rules)
- Yes, avoid them
1 participant
Summary
Removes the
--debuggerflag from theflask runcommand indocker/docker-bootstrap.sh.The Werkzeug interactive debugger console (EVALEX) is not needed for development workflows in Docker — hot-reloading (
--reload) provides the primary developer benefit. The console is not used in normal development flows and adds unnecessary surface area when the server is bound to0.0.0.0.Changes
docker/docker-bootstrap.sh: removed--debuggerfrom theappcaseflask runinvocationTesting
docker compose upGET /consolereturns 404ps aux | grep flaskshows no--debuggerflag