refactor(chart): improve dashboard validation consistency in chart operations#40336
Draft
sha174n wants to merge 8 commits into
Draft
refactor(chart): improve dashboard validation consistency in chart operations#40336sha174n wants to merge 8 commits into
sha174n wants to merge 8 commits into
Conversation
Add clarifications for common vulnerability report categories that fall outside our security scope to help manage high-volume reporting and align with other Apache projects: - User enumeration through API responses or timing differences - Low-impact information disclosure (versions, generic errors) - Resource exhaustion requiring authentication - Missing security headers without demonstrable exploit This reduces triage overhead while focusing on genuine architectural risks.
Define vulnerabilities as issues with meaningful impact beyond intended security model, allowing low-impact technical edge cases to be classified as hardening rather than vulnerabilities. This provides clearer triage criteria for boundary variations and access control edge cases.
…b.com/sha174n/superset into docs/expand-security-scope-exclusions
Add missing ownership validation in UpdateChartCommand._validate_new_dashboard_access() to match CreateChartCommand behavior. Previously only checked visibility via access filter, now requires ownership to prevent chart injection into non-owned dashboards.
The previous fix appended DashboardsForbiddenError (a ForbiddenError, not a ValidationError) to the exceptions list, causing AttributeError in ChartInvalidError.normalized_messages() → HTTP 500 instead of 403. Fix: raise DashboardsForbiddenError directly (matching CreateChartCommand) and add a DashboardsForbiddenError except clause to the put() handler, consistent with the existing post() handler. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #40336 +/- ##
==========================================
- Coverage 64.18% 64.18% -0.01%
==========================================
Files 2592 2592
Lines 139036 139041 +5
Branches 32282 32284 +2
==========================================
+ Hits 89244 89246 +2
- Misses 48260 48262 +2
- Partials 1532 1533 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…rd-ownership-validation
…rd-ownership-validation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standardizes dashboard relationship validation logic between chart creation and update operations. Consolidates permission checking patterns for improved code consistency.
This PR ensures that both chart creation and update operations apply equivalent validation logic when establishing dashboard relationships.