chore(cypress): remove dead _skip spec files and skipped inline tests#40384
Merged
Conversation
The 27 _skip.* spec files are already excluded from CI by `excludeSpecPattern` in cypress.config.ts — they never run and only exist as dead code. Delete them. Also strip the 22 it.skip() tests from editmode.test.ts (all in the "Color consistency" describe block, permanently skipped because ECharts renders to canvas which Cypress can't inspect). The 1 active test is preserved. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
rusackas
requested review from
betodealmeida,
eschutho,
geido,
mistercrunch and
sadpandajoe
as code owners
Contributor
Code Review Agent Run #2cfc1cActionable Suggestions - 0Additional Suggestions - 10
Filtered by Review RulesBito filtered these suggestions based on rules created automatically for your feedback. Manage rules.
Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40384 +/- ##
=======================================
Coverage 64.21% 64.21%
=======================================
Files 2592 2592
Lines 139167 139167
Branches 32312 32312
=======================================
Hits 89361 89361
Misses 48273 48273
Partials 1533 1533
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sadpandajoe
approved these changes
May 22, 2026
kasiazjc
pushed a commit
that referenced
this pull request
May 26, 2026
…#40384) Co-authored-by: Claude <claude@anthropic.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
_skip.*spec files that are permanently excluded from CI viaexcludeSpecPattern: ['**/_skip.*']incypress.config.ts. These files never run and exist only as dead code.it.skip()tests fromeditmode.test.ts— all belong to theColor consistencydescribe block, permanently skipped because ECharts renders to canvas and Cypress cannot inspect canvas elements. The 1 activeit('should add charts')test is preserved along with the minimal helpers it needs.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A — no UI changes.
TESTING INSTRUCTIONS
cypress.config.tsstill listsexcludeSpecPattern: ['**/_skip.*'](no longer needed for the deleted files, but no change required)editmode.test.tsstill executes theshould add chartstest_skip.*filesADDITIONAL INFORMATION
🤖 Generated with Claude Code