Skip to content

chore(ci): limit /app/prefix matrix variant to master merges#40385

Merged
rusackas merged 1 commit into
masterfrom
chore/cypress-matrix-pr-opt
May 23, 2026
Merged

chore(ci): limit /app/prefix matrix variant to master merges#40385
rusackas merged 1 commit into
masterfrom
chore/cypress-matrix-pr-opt

Conversation

@rusackas
Copy link
Copy Markdown
Member

SUMMARY

Running both app_root variants ("" and "/app/prefix") on every PR doubles the number of E2E jobs (12 Cypress + 4 Playwright) for a check that is primarily relevant at integration time. This restricts the /app/prefix variant to push events (master merges), halving PR E2E compute while preserving full coverage on merged code.

The change uses GitHub Actions' fromJSON() expression in the matrix definition so the value is a proper array at runtime:

app_root: ${{ github.event_name == 'push' && fromJSON('["", "/app/prefix"]') || fromJSON('[""]') }}

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A — CI-only change, no UI impact.

TESTING INSTRUCTIONS

  • CI on this PR will show 6 Cypress + 2 Playwright jobs (PR-time count — only app_root: "").
  • A master merge will still trigger the full 12 Cypress + 4 Playwright jobs (both app_root variants).

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

No functional code changes — CI workflow only.

…right

Running both app_root variants ("" and "/app/prefix") on every PR
doubles the number of E2E jobs (12 Cypress + 4 Playwright) for a check
that only matters at integration time. Restrict the /app/prefix variant
to push-to-master, halving PR E2E compute while keeping full coverage on
merged code.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@bito-code-review
Copy link
Copy Markdown
Contributor

bito-code-review Bot commented May 22, 2026

Bito Automatic Review Skipped - Files Excluded

Bito didn't auto-review this change because all changed files are in the exclusion list for automatic reviews. No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the excluded files settings here, or contact your Bito workspace admin at evan@preset.io.

@github-actions github-actions Bot added the github_actions Pull requests that update GitHub Actions code label May 22, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.21%. Comparing base (e40648d) to head (dd056f2).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #40385   +/-   ##
=======================================
  Coverage   64.21%   64.21%           
=======================================
  Files        2592     2592           
  Lines      139167   139167           
  Branches    32312    32312           
=======================================
  Hits        89361    89361           
  Misses      48273    48273           
  Partials     1533     1533           
Flag Coverage Δ
javascript 67.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rusackas rusackas merged commit 2fa3bbd into master May 23, 2026
66 of 67 checks passed
@rusackas rusackas deleted the chore/cypress-matrix-pr-opt branch May 23, 2026 04:11
kasiazjc pushed a commit that referenced this pull request May 26, 2026
Co-authored-by: Claude <claude@anthropic.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants