Skip to content

fix (formatting): improve small number formatting logic#40457

Open
Jualhosting wants to merge 1 commit into
apache:masterfrom
Jualhosting:fix-percentage-formatting
Open

fix (formatting): improve small number formatting logic#40457
Jualhosting wants to merge 1 commit into
apache:masterfrom
Jualhosting:fix-percentage-formatting

Conversation

@Jualhosting
Copy link
Copy Markdown

@Jualhosting Jualhosting commented May 27, 2026

SUMMARY

Improves the formatting logic for small numbers to avoid display issues such as showing "0" for non-zero values below a certain threshold.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Unit tests have been added to verify the small number formatting logic.

ADDITIONAL INFORMATION

AI Assistance Disclosure

This PR was developed with the assistance of Antigravity (a Gemini-based AI coding assistant). The contributor has reviewed and validated all changes.

@dosubot dosubot Bot added the viz:charts:table Related to the Table chart label May 27, 2026
@bito-code-review
Copy link
Copy Markdown
Contributor

bito-code-review Bot commented May 27, 2026

Code Review Agent Run #3a4dd7

Actionable Suggestions - 0
Review Details
  • Files reviewed - 2 · Commit Range: b8180ed..b8180ed
    • superset-frontend/plugins/plugin-chart-ag-grid-table/src/utils/formatValue.ts
    • superset-frontend/plugins/plugin-chart-table/src/utils/formatValue.ts
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • Eslint (Linter) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@Jualhosting
Copy link
Copy Markdown
Author

Jualhosting commented May 27, 2026

Thanks for catching this! Added a typeof === 'string' check to safeguard the trim() call against malformed non-string config payloads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugins size/XS viz:charts:table Related to the Table chart

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Percentage number formatting in table not working on very small numbers in 5.0.0

1 participant