Skip to content

chore(mcp): revert browser-friendly hello page for GET /mcp from browsers#40467

Merged
aminghadersohi merged 1 commit into
masterfrom
revert-40309-research-mcp-hello-page
May 27, 2026
Merged

chore(mcp): revert browser-friendly hello page for GET /mcp from browsers#40467
aminghadersohi merged 1 commit into
masterfrom
revert-40309-research-mcp-hello-page

Conversation

@aminghadersohi
Copy link
Copy Markdown
Contributor

Reverts #40309 since this was accidently merged.

@bito-code-review
Copy link
Copy Markdown
Contributor

bito-code-review Bot commented May 27, 2026

Code Review Agent Run #29d36d

Actionable Suggestions - 0
Filtered by Review Rules

Bito filtered these suggestions based on rules created automatically for your feedback. Manage rules.

  • superset/mcp_service/mcp_config.py - 1
    • CWE-306: Missing Authentication Middleware · Line 347-349
Review Details
  • Files reviewed - 6 · Commit Range: cf13cf5..cf13cf5
    • MANIFEST.in
    • superset/mcp_service/hello.html
    • superset/mcp_service/jwt_verifier.py
    • superset/mcp_service/mcp_config.py
    • tests/unit_tests/mcp_service/test_jwt_verifier.py
    • tests/unit_tests/mcp_service/test_jwt_verifier_browser_hello.py
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • MyPy (Static Code Analysis) - ✔︎ Successful
    • Astral Ruff (Static Code Analysis) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@aminghadersohi aminghadersohi changed the title Revert "feat(mcp): return browser-friendly hello page for GET /mcp from browsers" revert(mcp): return browser-friendly hello page for GET /mcp from browsers May 27, 2026
@aminghadersohi aminghadersohi changed the title revert(mcp): return browser-friendly hello page for GET /mcp from browsers chore(mcp): revert browser-friendly hello page for GET /mcp from browsers May 27, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2026

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.18%. Comparing base (09a94fa) to head (cf13cf5).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
superset/mcp_service/jwt_verifier.py 0.00% 3 Missing ⚠️
superset/mcp_service/mcp_config.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #40467   +/-   ##
=======================================
  Coverage   64.18%   64.18%           
=======================================
  Files        2592     2592           
  Lines      139271   139256   -15     
  Branches    32337    32334    -3     
=======================================
  Hits        89385    89385           
+ Misses      48351    48336   -15     
  Partials     1535     1535           
Flag Coverage Δ
hive 39.22% <0.00%> (+<0.01%) ⬆️
mysql 58.73% <0.00%> (+0.01%) ⬆️
postgres 58.81% <0.00%> (+0.01%) ⬆️
presto 40.90% <0.00%> (+<0.01%) ⬆️
python 60.37% <0.00%> (+0.01%) ⬆️
sqlite 58.45% <0.00%> (+0.01%) ⬆️
unit 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aminghadersohi aminghadersohi merged commit fb60662 into master May 27, 2026
63 of 66 checks passed
@aminghadersohi aminghadersohi deleted the revert-40309-research-mcp-hello-page branch May 27, 2026 15:43
aminghadersohi added a commit to aminghadersohi/superset that referenced this pull request May 27, 2026
… revert

MCPJWTVerifier was removed in the master revert of the browser-friendly
hello page (apache#40467). Update mcp_config.py to import only DetailedJWTVerifier
and use JWTVerifier directly for the non-debug code path, matching the
current jwt_verifier.py interface.
aminghadersohi added a commit to aminghadersohi/superset that referenced this pull request May 27, 2026
… revert

MCPJWTVerifier was removed in the master revert of the browser-friendly
hello page (apache#40467). Update mcp_config.py to import only DetailedJWTVerifier
and use JWTVerifier directly for the non-debug code path, matching the
current jwt_verifier.py interface.
aminghadersohi added a commit to aminghadersohi/superset that referenced this pull request May 29, 2026
… revert

MCPJWTVerifier was removed in the master revert of the browser-friendly
hello page (apache#40467). Update mcp_config.py to import only DetailedJWTVerifier
and use JWTVerifier directly for the non-debug code path, matching the
current jwt_verifier.py interface.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants