Skip to content

fix(semantic layers): small fixes#40474

Draft
betodealmeida wants to merge 7 commits into
masterfrom
sl-fixes
Draft

fix(semantic layers): small fixes#40474
betodealmeida wants to merge 7 commits into
masterfrom
sl-fixes

Conversation

@betodealmeida
Copy link
Copy Markdown
Member

@betodealmeida betodealmeida commented May 27, 2026

SUMMARY

Small fixes for the configuration modal of semantic layers/views:

  1. Fix modal when editing semantic layer, preventing flash of type selector (839240e).
  2. Reset dependencies when parent changes in form, for example, change database -> schemas should reset (6f7d6ec).
  3. Make sure dropdown options are sorted (d9be8df).
  4. Show proper labels on dropdown instead of values (8c04f03).
  5. Auto populate a default SL name (75eced0).

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2026

Codecov Report

❌ Patch coverage is 37.28814% with 37 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.17%. Comparing base (b6f545e) to head (2ded2d7).
⚠️ Report is 22 commits behind head on master.

Files with missing lines Patch % Lines
...d/src/features/semanticLayers/jsonFormsHelpers.tsx 0.00% 22 Missing ⚠️
...src/features/semanticLayers/SemanticLayerModal.tsx 57.14% 12 Missing ⚠️
superset-frontend/src/pages/DatasetList/index.tsx 66.66% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #40474      +/-   ##
==========================================
- Coverage   64.18%   64.17%   -0.02%     
==========================================
  Files        2592     2592              
  Lines      139256   139305      +49     
  Branches    32334    32352      +18     
==========================================
+ Hits        89385    89400      +15     
- Misses      48336    48370      +34     
  Partials     1535     1535              
Flag Coverage Δ
javascript 67.31% <37.28%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant