fix(helm): wrap extraContainers with tpl to evaluate templates (#31877)#40616
Open
rusackas wants to merge 1 commit into
Open
fix(helm): wrap extraContainers with tpl to evaluate templates (#31877)#40616rusackas wants to merge 1 commit into
rusackas wants to merge 1 commit into
Conversation
All six deployment templates (beat, flower, worker, ws, node, init-job) now evaluate extraContainers with `tpl` before rendering, matching the existing pattern used for initContainers and extraVolumes. Bumps chart version 0.15.5 → 0.15.6 per the chart versioning policy; regenerates helm-docs README. Co-authored-by: Craig Ingram <cin@users.noreply.github.com> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
rusackas
requested review from
Antonio-RiveroMartnez,
craig-rueda,
dpgaspar,
michael-s-molina,
mistercrunch,
nytai and
villebro
as code owners
Contributor
Code Review Agent Run #67519cActionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Closes #31877
init.extraContainers(and all otherextraContainersfields) were rendered with plaintoYaml, so Go template expressions inside them were passed through as literal strings instead of being evaluated. This PR wraps each one withtplso template expressions work — matching the existing pattern already used forinitContainers,extraVolumes,command, andenvFromConfigMaps.Affected deployments:
supersetNode,supersetCeleryBeat,supersetCeleryFlower,supersetWorker,supersetWebsockets,init(job).Bumps chart version
0.15.5 → 0.15.6per the chart versioning policy; regenerateshelm-docsREADME.Co-authored by @cin (original fix in #31878 — this PR adds the version bump and helm-docs that were missing there).
BEFORE / AFTER SCREENSHOTS
N/A (Helm template change)
TESTING INSTRUCTIONS
helm templatea chart with atpl-using string insupersetNode.extraContainersand confirm it renders instead of appearing as a raw{{ }}literal.helm lint helm/superset— should pass.ADDITIONAL INFORMATION
init.extraContainers#31877🤖 Generated with Claude Code