chore(mcp): remove low-value list/info tools that fail agent-native policy#40690
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40690 +/- ##
==========================================
+ Coverage 64.19% 64.20% +0.01%
==========================================
Files 2666 2649 -17
Lines 143991 143315 -676
Branches 33108 33069 -39
==========================================
- Hits 92428 92018 -410
+ Misses 49950 49688 -262
+ Partials 1613 1609 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![codeant-ai-for-open-source[bot]](https://avatars.githubusercontent.com/u/151810221?s=60&v=4){kind=small}
Contributor
|
The flagged issue is correct. The |
Contributor
Code Review Agent Run #e8ebfeActionable Suggestions - 0Filtered by Review RulesBito filtered these suggestions based on rules created automatically for your feedback. Manage rules.
Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
…olicy Remove 8 MCP tools (list_action_logs, get_action_log_info, list_css_templates, get_css_template_info, list_plugins, get_plugin_info, list_themes, get_theme_info) because they expose admin/infrastructure resources with no user-facing workflow value per the agent-native tool policy. Also removes the action_log runtime config guard from _apply_config_guards since those tools no longer exist, and updates the system prompt to reflect the removal.
Remove test cases for the action_log config guard (which no longer exists), update test_no_disabled_tools_returns_full_instructions to not assert on removed tools, and retarget test_config_guard_tools_excluded_from_instructions to the GLOBAL_TASK_FRAMEWORK guard (the only remaining config guard). Also drops unused fab_security_views/log_view params from _make_flask_app_mock.
…template/plugin/theme tools Delete entire module directories (source + tests) for the 4 removed tool groups: action_log, css_template, plugin, theme. Also remove their CSS_TEMPLATE_* and THEME_* constants from common/schema_discovery.py, strip css_template and theme support from get_schema tool and constants.ModelType, and drop the corresponding test cases from test_get_schema.py. Nothing in the codebase now references any of the 8 removed tool names.
aminghadersohi
force-pushed
the
sc-107899-mcp-remove-low-value-tools
branch
from
1f8aff5 to
4080da8
Compare
Contributor
Code Review Agent Run #311ad8Actionable Suggestions - 0Additional Suggestions - 1
Filtered by Review RulesBito filtered these suggestions based on rules created automatically for your feedback. Manage rules.
Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Removes 8 MCP tools that were identified as low-value under our agent-native policy: resources that are purely admin/infrastructure CRUD with no user-facing workflow value.
Removed tools:
action_log:list_action_logs,get_action_log_infocss_template:list_css_templates,get_css_template_infoplugin:list_plugins,get_plugin_infotheme:list_themes,get_theme_infoPolicy rationale: These tools expose low-level admin/infrastructure resources. Their primary user is an IT admin acting through the API, not an LLM helping an end user with data work.
Full cleanup — nothing left behind:
action_log/,css_template/,plugin/,theme/— including all schemas, DAOs, and empty__init__.pyfiles (source + test mirrors)css_templateandthemesupport fromget_schematool (factory functions, routing dict, permission map, docstring)CSS_TEMPLATE_*andTHEME_*constants andget_css_template_columns/get_theme_columnsfunctions fromcommon/schema_discovery.py"css_template"and"theme"fromconstants.ModelType_apply_config_guardstest_get_schema.pyandtest_mcp_tool_registration.pyBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A — no UI changes.
TESTING INSTRUCTIONS
list_toolsget_schemarejectsmodel_type="css_template"andmodel_type="theme"with a validation errorpytest tests/unit_tests/mcp_service/ -xto confirm all tests passADDITIONAL INFORMATION