Skip to content

chore: correct typos in config.py and models_test.py comments#40706

Merged
hainenber merged 1 commit into
apache:masterfrom
1Burhanuddin:patch-1
Jun 3, 2026
Merged

chore: correct typos in config.py and models_test.py comments#40706
hainenber merged 1 commit into
apache:masterfrom
1Burhanuddin:patch-1

Conversation

@1Burhanuddin
Copy link
Copy Markdown
Contributor

SUMMARY

Fixed two small spelling typos in code comments:

  1. superset/config.py line 1196: anndand
    • Comment said: "This feature is deprecated, annd will be removed"
  2. tests/unit_tests/connectors/sqla/models_test.py line 272: hanndlehandle
    • Docstring said: "can hanndle custom SQL"

TESTING INSTRUCTIONS

No functional changes — only comment/docstring text was modified. No tests needed.

ADDITIONAL INFORMATION

  • Has associated issue:
  • - [ ] Required feature flags:

@bito-code-review
Copy link
Copy Markdown
Contributor

bito-code-review Bot commented Jun 3, 2026

Code Review Agent Run #5900a5

Actionable Suggestions - 0
Review Details
  • Files reviewed - 2 · Commit Range: 2896826..2896826
    • superset/config.py
    • tests/unit_tests/connectors/sqla/models_test.py
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • MyPy (Static Code Analysis) - ✔︎ Successful
    • Astral Ruff (Static Code Analysis) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@hainenber hainenber changed the title fix: correct typos in config.py and models_test.py comments chore: correct typos in config.py and models_test.py comments Jun 3, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.08%. Comparing base (b9dc9d7) to head (2896826).
⚠️ Report is 13 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #40706   +/-   ##
=======================================
  Coverage   64.08%   64.08%           
=======================================
  Files        2663     2663           
  Lines      143289   143289           
  Branches    32952    32952           
=======================================
  Hits        91832    91832           
  Misses      49871    49871           
  Partials     1586     1586           
Flag Coverage Δ
hive 39.79% <ø> (ø)
mysql 58.47% <ø> (ø)
postgres 58.55% <ø> (ø)
presto 41.39% <ø> (ø)
python 60.03% <ø> (ø)
sqlite 58.16% <ø> (ø)
unit 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hainenber hainenber merged commit e5ff6de into apache:master Jun 3, 2026
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants