Skip to content

feat(ListView): expose expandable prop#40765

Open
alexandrusoare wants to merge 2 commits into
masterfrom
alexandrusoare/feat/expose-expandable-prop
Open

feat(ListView): expose expandable prop#40765
alexandrusoare wants to merge 2 commits into
masterfrom
alexandrusoare/feat/expose-expandable-prop

Conversation

@alexandrusoare
Copy link
Copy Markdown
Contributor

SUMMARY

Pass through the antd expandable prop from ListViewTableCollectionTable. The prop already exists on the underlying antd Table but is blocked by the two wrapper components. Prop forwarding only — no new logic or behavioral change.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.09%. Comparing base (45a6164) to head (db839aa).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #40765      +/-   ##
==========================================
+ Coverage   64.07%   64.09%   +0.01%     
==========================================
  Files        2664     2663       -1     
  Lines      143831   143581     -250     
  Branches    33084    33034      -50     
==========================================
- Hits        92160    92027     -133     
+ Misses      50062    49952     -110     
+ Partials     1609     1602       -7     
Flag Coverage Δ
javascript 67.63% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alexandrusoare alexandrusoare marked this pull request as ready for review June 5, 2026 14:42
@dosubot dosubot Bot added change:frontend Requires changing the frontend listview Namespace | Anything related to lists, such as Dashboards, Charts, Datasets, etc. labels Jun 5, 2026
@bito-code-review
Copy link
Copy Markdown
Contributor

bito-code-review Bot commented Jun 5, 2026

Code Review Agent Run #93678f

Actionable Suggestions - 0
Review Details
  • Files reviewed - 3 · Commit Range: 56e0bd6..db839aa
    • superset-frontend/packages/superset-ui-core/src/components/Table/index.tsx
    • superset-frontend/packages/superset-ui-core/src/components/TableCollection/index.tsx
    • superset-frontend/src/components/ListView/ListView.tsx
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change:frontend Requires changing the frontend listview Namespace | Anything related to lists, such as Dashboards, Charts, Datasets, etc. packages size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants