Skip to content

test(core): add unit tests for split function#40819

Open
dylancavalcante wants to merge 1 commit into
apache:masterfrom
PedroHhenriq:test/add-split-unit-tests
Open

test(core): add unit tests for split function#40819
dylancavalcante wants to merge 1 commit into
apache:masterfrom
PedroHhenriq:test/add-split-unit-tests

Conversation

@dylancavalcante
Copy link
Copy Markdown

SUMMARY

Adds unit tests for the split utility function located in superset/utils/core.py.

The test suite includes both black-box and white-box test cases to validate expected behavior and exercise key execution paths of the function.

Black-box tests cover:

  • Empty string input
  • Leading delimiter
  • Trailing delimiter
  • Delimiter-only string
  • Nested parentheses

White-box tests cover:

  • Delimiter found branch
  • Delimiter not found branch
  • Parentheses handling branch
  • Escaped quote handling branch

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Not applicable.

TESTING INSTRUCTIONS

Run:

pytest --noconftest tests/unit_tests/utils/test_split.py -v

Expected result:

9 passed

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration
  • Introduces new feature or API
  • Removes existing feature or API

@bito-code-review
Copy link
Copy Markdown
Contributor

bito-code-review Bot commented Jun 5, 2026

Code Review Agent Run #9e8416

Actionable Suggestions - 0
Review Details
  • Files reviewed - 1 · Commit Range: b2c4105..b2c4105
    • tests/unit_tests/utils/test_split.py
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • MyPy (Static Code Analysis) - ✔︎ Successful
    • Astral Ruff (Static Code Analysis) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 6, 2026

Deploy Preview for superset-docs-preview ready!

Name Link
🔨 Latest commit b2c4105
🔍 Latest deploy log https://app.netlify.com/projects/superset-docs-preview/deploys/6a2362edb338960008253ef5
😎 Deploy Preview https://deploy-preview-40819--superset-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant