feat(build): update Node version to v24#40835
Conversation
github-actions
Bot
added
doc
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![codeant-ai-for-open-source[bot]](https://avatars.githubusercontent.com/u/151810221?s=60&v=4){kind=small}
|
The flagged issue is correct. The To resolve this, you should update the "engines": {
"node": "^24.16.0",
"npm": "^11.13.0"
}I have validated this against the provided PR diff. Would you like me to fetch all other comments on this PR to see if there are additional issues you would like to address? |
![bito-code-review[bot]](https://avatars.githubusercontent.com/in/1061978?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review Agent Run #cf621e
Actionable Suggestions - 1
-
superset-websocket/.nvmrc - 1
- Inconsistent Node.js version · Line 1-1
Filtered by Review Rules
Bito filtered these suggestions based on rules created automatically for your feedback. Manage rules.
-
superset-websocket/utils/client-ws-app/.nvmrc - 1
- Inconsistent Node version across files · Line 1-1
Review Details
-
Files reviewed - 5 · Commit Range:
bf9e2fb..bf9e2fb- docs/.nvmrc
- superset-embedded-sdk/.nvmrc
- superset-frontend/.nvmrc
- superset-websocket/.nvmrc
- superset-websocket/utils/client-ws-app/.nvmrc
-
Files skipped - 2
- superset-frontend/package-lock.json - Reason: Filter setting
- superset-frontend/package.json - Reason: Filter setting
-
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
Bito Usage Guide
Commands
Type the following command in the pull request comment and save the comment.
-
/review- Manually triggers a full AI review. -
/pause- Pauses automatic reviews on this pull request. -
/resume- Resumes automatic reviews. -
/resolve- Marks all Bito-posted review comments as resolved. -
/abort- Cancels all in-progress reviews.
Refer to the documentation for additional commands.
Configuration
This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.
Documentation & Help
AI Code Review powered by
hainenber
requested review from
betodealmeida,
craig-rueda,
dpgaspar,
eschutho,
geido,
kgabryje,
mistercrunch,
nytai,
rusackas,
sadpandajoe and
villebro
as code owners
github-actions
Bot
added
github_actions
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40835 +/- ##
=======================================
Coverage 64.14% 64.14%
=======================================
Files 2650 2650
Lines 143455 143455
Branches 33097 33097
=======================================
Hits 92024 92024
Misses 49824 49824
Partials 1607 1607
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Code Review Agent Run #9e9584Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
1 participant
feat(build): update Node version to v24
SUMMARY
Updating project's Node version to v24 across all sub-projects. Node v22 is far from EoL but perf improvements from Node v24 is so critical for us atm as it'd help speeding up quite a lot of processes (
dev,testandbuild) both locally and CI.According to Gemini, these are possible benefits
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
Green CI and manual smoke test
ADDITIONAL INFORMATION