chore(deps-dev): update cx-oracle requirement from <8.4,>8.0.0 to >=8.3.0,<8.4#41088
chore(deps-dev): update cx-oracle requirement from <8.4,>8.0.0 to >=8.3.0,<8.4#41088dependabot[bot] wants to merge 1 commit into
Conversation
Updates the requirements on [cx-oracle](https://github.com/oracle/python-cx_Oracle) to permit the latest version. - [Release notes](https://github.com/oracle/python-cx_Oracle/releases) - [Commits](oracle/python-cx_Oracle@8.0.1...8.3.0) --- updated-dependencies: - dependency-name: cx-oracle dependency-version: 8.3.0 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
![bito-code-review[bot]](https://avatars.githubusercontent.com/in/1061978?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review Agent Run #ec356a
Actionable Suggestions - 1
-
pyproject.toml - 1
- Deprecated cx-Oracle vs oracledb mismatch · Line 180-180
Review Details
-
Files reviewed - 1 · Commit Range:
b0570df..b0570df- pyproject.toml
-
Files skipped - 0
-
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
Bito Usage Guide
Commands
Type the following command in the pull request comment and save the comment.
-
/review- Manually triggers a full AI review. -
/pause- Pauses automatic reviews on this pull request. -
/resume- Resumes automatic reviews. -
/resolve- Marks all Bito-posted review comments as resolved. -
/abort- Cancels all in-progress reviews.
Refer to the documentation for additional commands.
Configuration
This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.
Documentation & Help
AI Code Review powered by
| "geojson", | ||
| ] | ||
| oracle = ["cx-Oracle>8.0.0, <8.4"] | ||
| oracle = ["cx-Oracle>=8.3.0, <8.4"] |
There was a problem hiding this comment.
The oracle extra specifies cx-Oracle>=8.3.0,<8.4 but the codebase already migrated to oracledb (see superset/db_engine_specs/oracle.py line 38: "pypi_packages": ["oracledb"]). cx_Oracle was deprecated by Oracle in 2022, only supports Python ≤3.10, and has known build failures on Python 3.11+. This dependency is incompatible with Superset's requires-python = ">=3.10" and will fail to install or build on supported Python versions.
Code suggestion
Check the AI-generated fix before applying
--- pyproject.toml (line 180) ---
180:-oracle = ["cx-Oracle>=8.3.0, <8.4"]
180:+oracle = ["oracledb>=2.0.0,<3"]
Code Review Run #ec356a
Should Bito avoid suggestions like this for future reviews? (Manage Rules)
- Yes, avoid them
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #41088 +/- ##
==========================================
- Coverage 64.31% 64.25% -0.07%
==========================================
Files 2651 2660 +9
Lines 144677 144795 +118
Branches 33350 33384 +34
==========================================
- Hits 93054 93043 -11
- Misses 49972 50099 +127
- Partials 1651 1653 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Closing in favor of #41122 - rather than bump cx-Oracle, we're dropping it for |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
1 participant
Updates the requirements on cx-oracle to permit the latest version.
Release notes
Sourced from cx-oracle's releases.
Commits
5728cf5Try newer version of Sphinx.3a40eeaReadTheDocs only supports up to Python 3.8.fde9ec7ReadTheDocs requires configuration so make it happy.45118e0Preparing to release cx_Oracle 8.3.29ca919Add official support for Python 3.10.ae687ceImprove documentation for WHERE IN clauses.2d33fecTest suite improvements.9db9d69Batch loading documentation improvements.00dc44eUpdate ODPI-C.76157ddAdd note that change to MessageProperties.msgid marked the attributeDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)