Skip to content

fix(frontend): finish sentence-case conversion for time range buttons#41488

Merged
sadpandajoe merged 1 commit into
masterfrom
fix/followup-40435-follow-up-from-40435-fix-convert-all-cap
Jun 29, 2026
Merged

fix(frontend): finish sentence-case conversion for time range buttons#41488
sadpandajoe merged 1 commit into
masterfrom
fix/followup-40435-follow-up-from-40435-fix-convert-all-cap

Conversation

@rusackas

Copy link
Copy Markdown
Member

Follow-up to #40435.

That PR converted most ALL CAPS button labels to sentence case but missed the time range filter popover in the ListView filters (different component from the explore DateFilterLabel that #40435 did fix). This finishes the job.

Changes

  • components/ListView/Filters/TimeRange.tsx: CANCEL -> Cancel, APPLY -> Apply (matches the sentence-case convention used everywhere else for these buttons).
  • components/Chart/chartAction.ts: dropped a redundant QueryData & from a type assertion. The response is already inferred as QueryData, so re-asserting it in the intersection was redundant; response as { warning?: string | null } is enough.

The existing TimeRange.test.tsx queries these buttons with case-insensitive regex (/cancel/i, /apply/i), so no test changes are needed.

Test plan

  • Time range filter popover (list views): verify Cancel/Apply buttons render correctly
  • jest passes on TimeRange.test.tsx

🤖 Generated with Claude Code

Follow-up to #40435. Converts the remaining UPPERCASE CANCEL and APPLY
button labels in the ListView TimeRange filter popover to sentence case,
and drops a redundant intersection cast in chartAction.ts.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@dosubot dosubot Bot added the change:frontend Requires changing the frontend label Jun 27, 2026
@bito-code-review

bito-code-review Bot commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Code Review Agent Run #6310c4

Actionable Suggestions - 0
Filtered by Review Rules

Bito filtered these suggestions based on rules created automatically for your feedback. Manage rules.

  • superset-frontend/src/components/Chart/chartAction.ts - 1
Review Details
  • Files reviewed - 2 · Commit Range: 10aa48d..10aa48d
    • superset-frontend/src/components/Chart/chartAction.ts
    • superset-frontend/src/components/ListView/Filters/TimeRange.tsx
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • Eslint (Linter) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@codecov

codecov Bot commented Jun 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.95%. Comparing base (0a18779) to head (10aa48d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #41488   +/-   ##
=======================================
  Coverage   63.95%   63.95%           
=======================================
  Files        2664     2664           
  Lines      146217   146217           
  Branches    33731    33731           
=======================================
+ Hits        93511    93517    +6     
+ Misses      50991    50985    -6     
  Partials     1715     1715           
Flag Coverage Δ
javascript 68.96% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sadpandajoe sadpandajoe merged commit 11a4a17 into master Jun 29, 2026
70 checks passed
@sadpandajoe sadpandajoe deleted the fix/followup-40435-follow-up-from-40435-fix-convert-all-cap branch June 29, 2026 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change:frontend Requires changing the frontend size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants