fix(frontend): finish sentence-case conversion for time range buttons#41488
Conversation
Follow-up to #40435. Converts the remaining UPPERCASE CANCEL and APPLY button labels in the ListView TimeRange filter popover to sentence case, and drops a redundant intersection cast in chartAction.ts. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Code Review Agent Run #6310c4Actionable Suggestions - 0Filtered by Review RulesBito filtered these suggestions based on rules created automatically for your feedback. Manage rules.
Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #41488 +/- ##
=======================================
Coverage 63.95% 63.95%
=======================================
Files 2664 2664
Lines 146217 146217
Branches 33731 33731
=======================================
+ Hits 93511 93517 +6
+ Misses 50991 50985 -6
Partials 1715 1715
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Follow-up to #40435.
That PR converted most ALL CAPS button labels to sentence case but missed the time range filter popover in the ListView filters (different component from the explore
DateFilterLabelthat #40435 did fix). This finishes the job.Changes
components/ListView/Filters/TimeRange.tsx:CANCEL->Cancel,APPLY->Apply(matches the sentence-case convention used everywhere else for these buttons).components/Chart/chartAction.ts: dropped a redundantQueryData &from a type assertion. Theresponseis already inferred asQueryData, so re-asserting it in the intersection was redundant;response as { warning?: string | null }is enough.The existing
TimeRange.test.tsxqueries these buttons with case-insensitive regex (/cancel/i,/apply/i), so no test changes are needed.Test plan
jestpasses onTimeRange.test.tsx🤖 Generated with Claude Code