Skip to content

test(mcp): set embedded on update_dashboard test mock#41495

Merged
hainenber merged 1 commit into
apache:masterfrom
nytai:fix/mcp-update-dashboard-embedded-mock
Jun 28, 2026
Merged

test(mcp): set embedded on update_dashboard test mock#41495
hainenber merged 1 commit into
apache:masterfrom
nytai:fix/mcp-update-dashboard-embedded-mock

Conversation

@nytai

@nytai nytai commented Jun 27, 2026

Copy link
Copy Markdown
Member

SUMMARY

fixing failing test on main

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot Bot added the dashboard Namespace | Anything related to the Dashboard label Jun 27, 2026
@bito-code-review

bito-code-review Bot commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Code Review Agent Run #ae9266

Actionable Suggestions - 0
Review Details
  • Files reviewed - 1 · Commit Range: f21d666..f21d666
    • tests/unit_tests/mcp_service/dashboard/tool/test_update_dashboard.py
  • Files skipped - 0
  • Tools
    • MyPy (Static Code Analysis) - ✔︎ Successful
    • Astral Ruff (Static Code Analysis) - ✔︎ Successful
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@nytai nytai force-pushed the fix/mcp-update-dashboard-embedded-mock branch from f21d666 to 24f4aab Compare June 27, 2026 19:44
@codecov

codecov Bot commented Jun 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.52%. Comparing base (cd8ac41) to head (24f4aab).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #41495      +/-   ##
==========================================
+ Coverage   63.95%   64.52%   +0.56%     
==========================================
  Files        2664     2664              
  Lines      146219   146219              
  Branches    33731    33731              
==========================================
+ Hits        93517    94345     +828     
+ Misses      50987    50157     -830     
- Partials     1715     1717       +2     
Flag Coverage Δ
hive 39.22% <ø> (ø)
mysql 57.97% <ø> (ø)
postgres 58.03% <ø> (-0.01%) ⬇️
presto 40.80% <ø> (ø)
python 59.46% <ø> (+1.21%) ⬆️
sqlite 57.67% <ø> (ø)
unit 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bito-code-review

bito-code-review Bot commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Code Review Agent Run #bf26cd

Actionable Suggestions - 0
Review Details
  • Files reviewed - 1 · Commit Range: 24f4aab..24f4aab
    • tests/unit_tests/mcp_service/dashboard/tool/test_update_dashboard.py
  • Files skipped - 0
  • Tools
    • MyPy (Static Code Analysis) - ✔︎ Successful
    • Astral Ruff (Static Code Analysis) - ✔︎ Successful
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@hainenber hainenber merged commit 25c9f35 into apache:master Jun 28, 2026
59 checks passed
@rusackas

Copy link
Copy Markdown
Member

Thanks for tackling this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dashboard Namespace | Anything related to the Dashboard size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants