Skip to content

docs(admin/config): resolve misconfigured aws-iam Markdown file#41748

Merged
rusackas merged 1 commit into
masterfrom
resolve-misconfigured-aws-iam-docs
Jul 6, 2026
Merged

docs(admin/config): resolve misconfigured aws-iam Markdown file#41748
rusackas merged 1 commit into
masterfrom
resolve-misconfigured-aws-iam-docs

Conversation

@hainenber

Copy link
Copy Markdown
Contributor

docs(admin/config): resolve misconfigured aws-iam Markdown file

SUMMARY

Chore-y PR to resolve issue found on https://superset.apache.org/admin-docs/configuration/aws-iam

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before
image

After
image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber hainenber requested review from rusackas and sfirke July 3, 2026 14:31
@dosubot dosubot Bot added the doc Namespace | Anything related to documentation label Jul 3, 2026
@bito-code-review

bito-code-review Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Code Review Agent Run #a12901

Actionable Suggestions - 0
Review Details
  • Files reviewed - 1 · Commit Range: 741bc55..741bc55
    • docs/admin_docs/configuration/aws-iam.mdx
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@netlify

netlify Bot commented Jul 3, 2026

Copy link
Copy Markdown

Deploy Preview for superset-docs-preview ready!

Name Link
🔨 Latest commit 741bc55
🔍 Latest deploy log https://app.netlify.com/projects/superset-docs-preview/deploys/6a47c7afe9d94b0008d0e7a2
😎 Deploy Preview https://deploy-preview-41748--superset-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@rusackas rusackas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I think we do need an ASF license header in here though, right? I'd have to look at other pages to see how they have it added.

@rusackas

rusackas commented Jul 6, 2026

Copy link
Copy Markdown
Member

Whatever... CI is happy... if we need ASF license files everywhere and it's not catching here, then that's a separate problem to solve.

@rusackas rusackas merged commit 689b4f6 into master Jul 6, 2026
53 checks passed
@rusackas rusackas deleted the resolve-misconfigured-aws-iam-docs branch July 6, 2026 18:51
@hainenber

Copy link
Copy Markdown
Contributor Author

Agree. I'll chalk a follw-up PR to allow having ASF header for mdx files in docs AND still rendered correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Namespace | Anything related to documentation size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants