Skip to content

build(deps): upgrade react-markdown to v9 and remark-gfm to v4#41778

Merged
rusackas merged 2 commits into
masterfrom
build/upgrade-react-markdown-and-remark-gfm-to-next-major-version
Jul 6, 2026
Merged

build(deps): upgrade react-markdown to v9 and remark-gfm to v4#41778
rusackas merged 2 commits into
masterfrom
build/upgrade-react-markdown-and-remark-gfm-to-next-major-version

Conversation

@hainenber

@hainenber hainenber commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

build(deps): upgrade react-markdown to v9 and remark-gfm to v4

SUMMARY

Previously, these deps were pinned down to rehype-parse due to

However, thanks to @msyavuz's tremendous work on migrating the project to React 18, we can now resolve this issue naturally. I've looked at CHANGELOG for both deps and thankfully, only transformLinkUri -> urlTransform migration in SafeMarkdown.tsx is needed. No breaking changes in remark-gfm v4.

Tested manually to ensure no regression.

  1. Apostrophes highlighting words are working
Screen.Recording.2026-07-05.at.21.53.15.mov
  1. Table is renderable and not err out
Screen.Recording.2026-07-05.at.21.56.00.mov

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

Green CI for frontier acceptance criterion

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

…version

Signed-off-by: hainenber <dotronghai96@gmail.com>
@bito-code-review

bito-code-review Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Code Review Agent Run #0156c0

Actionable Suggestions - 0
Review Details
  • Files reviewed - 1 · Commit Range: 5a1ad47..55796f6
    • superset-frontend/packages/superset-ui-core/src/components/SafeMarkdown/SafeMarkdown.tsx
  • Files skipped - 4
    • .github/dependabot.yml - Reason: Filter setting
    • superset-frontend/package-lock.json - Reason: Filter setting
    • superset-frontend/package.json - Reason: Filter setting
    • superset-frontend/packages/superset-ui-core/package.json - Reason: Filter setting
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@hainenber hainenber requested a review from rebenitez1802 July 5, 2026 14:57
@hainenber hainenber changed the title build(deps): upgrade react-markdown and remark-gfm to next major version build(deps): upgrade react-markdown to v9 and remark-gfm to v4 Jul 5, 2026
@codecov

codecov Bot commented Jul 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.70%. Comparing base (3303d4e) to head (55796f6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #41778   +/-   ##
=======================================
  Coverage   64.70%   64.70%           
=======================================
  Files        2686     2686           
  Lines      148626   148626           
  Branches    34298    34298           
=======================================
  Hits        96164    96164           
  Misses      50697    50697           
  Partials     1765     1765           
Flag Coverage Δ
javascript 69.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rusackas rusackas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hainenber, LGTM. Nice to see those dependabot ignores finally come out too.

One thing I dug into before stamping: v9's urlTransform applies to image srcs as well, where the old transformLinkUri only ever saw link hrefs. The blocklist still kills javascript/vbscript/data everywhere and images just get slightly more tolerant of inert custom schemes, so I think that's fine (arguably more consistent with #26211). The function name and docstring still say links-only though... worth a small rename/comment touchup in a follow-up, not blocking.

Approving, and I'll merge soon if there's no objection.

@rusackas rusackas merged commit ad8e6d4 into master Jul 6, 2026
70 checks passed
@rusackas rusackas deleted the build/upgrade-react-markdown-and-remark-gfm-to-next-major-version branch July 6, 2026 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants