build(deps): upgrade react-markdown to v9 and remark-gfm to v4#41778
Conversation
…version Signed-off-by: hainenber <dotronghai96@gmail.com>
Code Review Agent Run #0156c0Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help |
…m-to-next-major-version
react-markdown and remark-gfm to next major versionreact-markdown to v9 and remark-gfm to v4
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #41778 +/- ##
=======================================
Coverage 64.70% 64.70%
=======================================
Files 2686 2686
Lines 148626 148626
Branches 34298 34298
=======================================
Hits 96164 96164
Misses 50697 50697
Partials 1765 1765
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rusackas
left a comment
There was a problem hiding this comment.
Thanks @hainenber, LGTM. Nice to see those dependabot ignores finally come out too.
One thing I dug into before stamping: v9's urlTransform applies to image srcs as well, where the old transformLinkUri only ever saw link hrefs. The blocklist still kills javascript/vbscript/data everywhere and images just get slightly more tolerant of inert custom schemes, so I think that's fine (arguably more consistent with #26211). The function name and docstring still say links-only though... worth a small rename/comment touchup in a follow-up, not blocking.
Approving, and I'll merge soon if there's no objection.
build(deps): upgrade
react-markdownto v9 andremark-gfmto v4SUMMARY
Previously, these deps were pinned down to
rehype-parsedue toTransitive dep mismatch between
react-markdownandremark-gfm(ref PR).react-markdownneeds React 18+However, thanks to @msyavuz's tremendous work on migrating the project to React 18, we can now resolve this issue naturally. I've looked at CHANGELOG for both deps and thankfully, only
transformLinkUri -> urlTransformmigration in SafeMarkdown.tsx is needed. No breaking changes inremark-gfmv4.Tested manually to ensure no regression.
Screen.Recording.2026-07-05.at.21.53.15.mov
Screen.Recording.2026-07-05.at.21.56.00.mov
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
Green CI for frontier acceptance criterion
ADDITIONAL INFORMATION