fix(a11y): add aria-label to remove-sheet icon button in Google Sheets catalog

[eschutho]

WCAG rule

2.1 SC 4.1.2 (Name, Role, Value) — Level A.

What changed

The "remove sheet" Icons.CloseOutlined button in the Google Sheets catalog section of the database connection form (TableCatalog.tsx) — shown next to each sheet entry when there's more than one — had an onClick handler but no accessible name. Screen reader users tabbing to it heard only a generic "close" announcement (from the icon's auto-generated fallback label), with no indication of what it removes or which entry it belongs to.

Added aria-label={t('Remove sheet')}, matching the existing "Remove {noun}" convention already used by the sibling Remove filter button in FilterTitleContainer.tsx.

Behavior

Unchanged — purely additive, no visual or functional change.

Test plan

• Open a database connection modal for a Google Sheets connection with 2+ sheets configured.
• Tab to the "X" icon next to a sheet entry.
• Verify a screen reader announces "Remove sheet, button" (previously announced a generic unlabeled "close"/button).
• Confirm clicking still removes the correct sheet entry (no behavior change).

[bito-code-review]

Code Review Agent Run #cfc935

Actionable Suggestions - 0

Review Details

• Files reviewed - 1 · Commit Range: d3de929..d3de929

  • superset-frontend/src/features/databases/DatabaseModal/DatabaseConnectionForm/TableCatalog.tsx
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.72%. Comparing base (8382683) to head (d3de929).

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #41796      +/-   ##
==========================================
- Coverage   64.72%   64.72%   -0.01%     
==========================================
  Files        2686     2686              
  Lines      148651   148651              
  Branches    34309    34309              
==========================================
- Hits        96218    96213       -5     
- Misses      50671    50676       +5     
  Partials     1762     1762              

Flag	Coverage Δ
javascript	69.57% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.