Skip to content

NOJIRA: Enable Apache Maven wrapper plugin#122

Closed
mmoayyed wants to merge 2 commits intoapache:masterfrom
mmoayyed:NOJIRA-MavenWrapper
Closed

NOJIRA: Enable Apache Maven wrapper plugin#122
mmoayyed wants to merge 2 commits intoapache:masterfrom
mmoayyed:NOJIRA-MavenWrapper

Conversation

@mmoayyed
Copy link
Contributor

This pull request enables the maven-wrapper for Syncope. Main objectives are:

  1. Local builds do not need to have (the right version of ) Apache Maven locally installed; specially relevant for Windows.
  2. Control the build via the proper Apache Maven version.

The command to update the wrapper would be: mvn -N io.takari:maven:0.7.6:wrapper (or whatever is the version of the plugin)

Notes:

By default, the Maven Wrapper JAR archive is added to the using project as small binary file .mvn/wrapper/maven-wrapper.jar. It is used to bootstrap the download and invocation of Maven from the wrapper shell scripts. If your project is not allowed to contain binary files like this, you can configure your version control system to exclude checkin/commit of the wrapper jar.

If the JAR is not found to be available by the scripts they will attempt to download the file from the URL specified in .mvn/wrapper/maven-wrapper.properties under wrapperUrl and put it in place. The download is attempted via curl, wget and, as last resort, by compiling the ./mvn/wrapper/MavenWrapperDownloader.java file and executing the resulting class.

@ilgrosso
Copy link
Member

@mmoayyed I am not sure of the benefits of adding this: would you mind initiating a [DISCUSS] thread on dev@ on the topic? Thanks!

@mmoayyed mmoayyed changed the title NoJIRA: Enable Apache Maven wrapper plugin NOJIRA: Enable Apache Maven wrapper plugin Sep 24, 2019
@mmoayyed
Copy link
Contributor Author

Based on discussions on the dev mailing list, we're going to punt this one.

@mmoayyed mmoayyed closed this Sep 27, 2019
@mmoayyed mmoayyed deleted the NOJIRA-MavenWrapper branch September 27, 2019 08:52
@ilgrosso
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants