Skip to content

[SYNCOPE-1969] Adding missing SAMLRegisteredService configurations#1395

Merged
ilgrosso merged 3 commits into
apache:4_1_Xfrom
valerio-crescia:SYNCOPE-1969
May 25, 2026
Merged

[SYNCOPE-1969] Adding missing SAMLRegisteredService configurations#1395
ilgrosso merged 3 commits into
apache:4_1_Xfrom
valerio-crescia:SYNCOPE-1969

Conversation

@valerio-crescia
Copy link
Copy Markdown
Contributor

No description provided.

@ilgrosso
Copy link
Copy Markdown
Member

@valerio-crescia please check the NPE in

https://github.com/apache/syncope/actions/runs/26388854868/job/77673589006?pr=1395#step:7:6135

it looks like logoutResponseBinding needs a default to be set in ‎SAML2SPClientAppTO

@valerio-crescia
Copy link
Copy Markdown
Contributor Author

@valerio-crescia please check the NPE in

https://github.com/apache/syncope/actions/runs/26388854868/job/77673589006?pr=1395#step:7:6135

it looks like logoutResponseBinding needs a default to be set in ‎SAML2SPClientAppTO

Can I skip the property if it is null?

        if(sp.getSigningCredentialType() != null) {
            service.setSigningCredentialType(sp.getSigningCredentialType().name());
        }

@ilgrosso ilgrosso merged commit 2039dce into apache:4_1_X May 25, 2026
26 of 34 checks passed
@ilgrosso ilgrosso deleted the SYNCOPE-1969 branch May 25, 2026 12:51
@ilgrosso
Copy link
Copy Markdown
Member

Thank you @valerio-crescia I will cherry-pick these changes to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants