Skip to content

Switch to CAS 6.4#258

Merged
mmoayyed merged 16 commits intoapache:masterfrom
mmoayyed:64rc3
Apr 23, 2021
Merged

Switch to CAS 6.4#258
mmoayyed merged 16 commits intoapache:masterfrom
mmoayyed:64rc3

Conversation

@mmoayyed
Copy link
Contributor

@mmoayyed mmoayyed commented Apr 6, 2021

No description provided.

@ilgrosso
Copy link
Member

ilgrosso commented Apr 6, 2021

@mmoayyed please merge latest changes from master to fix build with Payara.

About CAS / Pac4j upgrade, I am getting the same exceptions locally: https://github.com/apache/syncope/runs/2275643884?check_suite_focus=true#step:7:4202

@mmoayyed
Copy link
Contributor Author

mmoayyed commented Apr 6, 2021

It seems like the exceptions are due to the fact that xmlsectool ships with and leaks opensaml 4.0.1, whereas the configuration requires 4.1.0. I will play around with some exclusion rules to see what I can do. Alternatively, I might be able to force the opensaml version to use 4.1.0, which I think is likely the better option.

@mmoayyed
Copy link
Contributor Author

mmoayyed commented Apr 6, 2021

Fixed the exceptions locally. Further testing however shows that there are number of other issues regarding logout operations for SAML2 and OIDC. So, at the moment it's not feasible to upgrade to RC3, and I will work on fixes to make sure we can upgrade to RC4 in a few weeks.

Changing PR to Draft status.

@mmoayyed mmoayyed marked this pull request as draft April 6, 2021 12:29
@mmoayyed mmoayyed changed the title Switch to CAS 6.4 RC3 Switch to CAS 6.4 Apr 7, 2021
Copy link
Member

@ilgrosso ilgrosso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmoayyed mmoayyed marked this pull request as ready for review April 23, 2021 10:04
@mmoayyed mmoayyed merged commit 833c002 into apache:master Apr 23, 2021
@mmoayyed mmoayyed deleted the 64rc3 branch April 23, 2021 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants