[SYSTEMDS-2555] Federated transform dummycoding encoding decoding #1031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kev-inn
force-pushed
the
fed_transform_dummy
branch
2 times, most recently
from
0fb7139 to
f9994e7
Compare
kev-inn
force-pushed
the
fed_transform_dummy
branch
from
c31c203 to
8c879a4
Compare
Contributor
|
LGTM - thanks @kev-inn for this solid patch. I only did some minor cleanups (arrays.fill/streams where applicable, removed csv property handling on read) and left a performance TODO. For dummycode decode, it would be important (once we come to performance improvements) to work with sparse matrices directly to avoid unnecessarily bad asymptotic behavior (O(m n log n) vs O(nnz)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds dummycoding support for federated
transformencodeandtransformdecode.Merge PR #1027 first.