[SYSTEMDS-2661, 2662]: Pipelines Optimizer and various minor built-ins#1055
[SYSTEMDS-2661, 2662]: Pipelines Optimizer and various minor built-ins#1055Shafaq-Siddiqi wants to merge 2 commits into
Conversation
This commit contains, 1. Optimizer for cleaning pipelines 2. Minor built-ins imputeByMean, imputeByMedian, frameSort, vectorToCsv.dml 3. minor fixes for resolving warnings in different dml scripts
corepointer
left a comment
corepointer
left a comment
There was a problem hiding this comment.
Please fix the mentioned external dependencies. I ran the Enumerator and Bandit JUnit tests just fine after rebasing to current main branch, so this should be merge-able once the issues are addressed.
Thx for your effort @Shafaq-Siddiqi ! 😄
| public void testEnumerator(){runEnumerator(Types.ExecMode.SINGLE_NODE);}; | ||
|
|
||
|
|
||
| private void runEnumerator(LopProperties.ExecType instType) | ||
| private void runEnumerator(Types.ExecMode instType) |
There was a problem hiding this comment.
I don't think that change is necessary. Common practice is to name your test testEnumeratorCP and use ExecType.
| { | ||
| # load the primitives | ||
| physical = as.frame("") | ||
| resource_dir = "./scripts/staging/pipelines/"; |
There was a problem hiding this comment.
In a builtin function we shouldn't rely on external data that is not shipped in the binary distribution (the staging directory is specifically excluded when building the release artifact).
| return (List[Unknown] paramList) | ||
| { | ||
| # load the hyper-parameters values | ||
| resource_dir = "./scripts/staging/pipelines/"; |
There was a problem hiding this comment.
Same here - don't rely on external files that are not shipped.
|
The functionalities with minor improvements are merged into a new PR with the same name. |
2 participants
This commit contains,