Skip to content

Fix FederatedWorkerHandlerTest#1057

Closed
sebwrede wants to merge 3 commits intoapache:masterfrom
sebwrede:FederatedWorkerHandlerTestFix
Closed

Fix FederatedWorkerHandlerTest#1057
sebwrede wants to merge 3 commits intoapache:masterfrom
sebwrede:FederatedWorkerHandlerTestFix

Conversation

@sebwrede
Copy link
Contributor

No description provided.

@sebwrede sebwrede marked this pull request as ready for review September 18, 2020 09:26
@sebwrede
Copy link
Contributor Author

The failing tests could be caused by the shared target space used by both federated and privacy tests. The tests never fail when I run it locally and they only fail sometimes when running it through GitHub Actions, so even if the privacy tests pass now, we cannot know for sure if we only run it once. I fixed FederatedWorkerHandlerTest to use its own target space and I believe this has fixed the problem.

@Baunsgaard
Copy link
Contributor

The failing tests could be caused by the shared target space used by both federated and privacy tests. The tests never fail when I run it locally and they only fail sometimes when running it through GitHub Actions, so even if the privacy tests pass now, we cannot know for sure if we only run it once. I fixed FederatedWorkerHandlerTest to use its own target space and I believe this has fixed the problem.

sounds reasonable, Lets try it out, we will see if it becomes stable by following commits!

also the pr LGTM, will merge shortly

@sebwrede sebwrede deleted the FederatedWorkerHandlerTestFix branch October 8, 2021 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants