[SYSTEMDS-2663, 2664] Prepare native instructions for release 2.0 #1063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
corepointer
commented
Sep 23, 2020
corepointer
commented
- pulled in a few CMake tricks from gpu codegen dev branch to unify lib naming
- verify MKL and OpenBLAS working
- cleanup native lib loader class (NativeHelper)
- build script for Windows
* pulled in a few CMake tricks from gpu codegen dev branch to unify lib naming * verify MKL and OpenBLAS working * cleanup native lib loader class (NativeHelper) * build script for Windows
Baunsgaard
reviewed
Sep 23, 2020
| * @return true if operating system is supported | ||
| */ | ||
| private static boolean isSupportedOS() { | ||
| if(SystemUtils.IS_OS_LINUX || SystemUtils.IS_OS_WINDOWS) { |
Contributor
There was a problem hiding this comment.
could it not also include UNIX?
for mac support?
If not it would make sense to add a task on JIRA for this
Contributor
Author
There was a problem hiding this comment.
We don't have Mac support anymore. We can put it on the wish list in JIRA 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.