Skip to content

Postprocess Privacy Constraints Before Lineage Cache#1074

Closed
sebwrede wants to merge 3 commits intoapache:masterfrom
sebwrede:PostProcessPrivacy
Closed

Postprocess Privacy Constraints Before Lineage Cache#1074
sebwrede wants to merge 3 commits intoapache:masterfrom
sebwrede:PostProcessPrivacy

Conversation

@sebwrede
Copy link
Copy Markdown
Contributor

This PR will make sure that privacy constraints are propagated to output variables before the result of the instruction is cached. This is under the assumption that the caching does not only use the CPOperand outputs, but also uses the variables stored in the execution context.

@phaniarnab
Copy link
Copy Markdown
Contributor

What will happen if the result is reused from lineage cache?
I suggest a small test to check. You can enable lineage reuse by passing -lineage reuse_full option.

@sebwrede
Copy link
Copy Markdown
Contributor Author

sebwrede commented Oct 1, 2020

I have now added a test and put the postprocessing of privacy constraints outside the lineage cache if-block in ProgramBlock. In this way, the privacy constraints will be propagated even if the result has been read from the cache.
I needed to add a few lines which is also a part of another pending PR to propagate the fine-grained constraints and to release matrix input.

@phaniarnab
Copy link
Copy Markdown
Contributor

Thanks. Looks good. 🦾
LGTM (if all the tests pass).

@phaniarnab phaniarnab closed this Oct 14, 2020
@sebwrede sebwrede deleted the PostProcessPrivacy branch October 8, 2021 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants