Postprocess Privacy Constraints Before Lineage Cache#1074
Closed
sebwrede wants to merge 3 commits intoapache:masterfrom
Closed
Postprocess Privacy Constraints Before Lineage Cache#1074sebwrede wants to merge 3 commits intoapache:masterfrom
sebwrede wants to merge 3 commits intoapache:masterfrom
Conversation
Contributor
|
What will happen if the result is reused from lineage cache? |
Contributor
Author
|
I have now added a test and put the postprocessing of privacy constraints outside the lineage cache if-block in ProgramBlock. In this way, the privacy constraints will be propagated even if the result has been read from the cache. |
Contributor
|
Thanks. Looks good. 🦾 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will make sure that privacy constraints are propagated to output variables before the result of the instruction is cached. This is under the assumption that the caching does not only use the CPOperand outputs, but also uses the variables stored in the execution context.