[SYSTEMDS-2735] GMM Predict for clustering new instances#1108
Closed
Shafaq-Siddiqi wants to merge 2 commits intoapache:masterfrom
Closed
[SYSTEMDS-2735] GMM Predict for clustering new instances#1108Shafaq-Siddiqi wants to merge 2 commits intoapache:masterfrom
Shafaq-Siddiqi wants to merge 2 commits intoapache:masterfrom
Conversation
Shafaq-Siddiqi
changed the title
Contributor
|
LGTM - thanks for the patch @Shafaq-Siddiqi. Generally this looks very good. I just renamed the new builtin to gmmPredict for consistency, changed the formatting a bit, added the missing reset of rewrite flags in the test, and disabled the spark tests (as forced spark mode at algorithm level is a bit too much here). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Predict method for Gaussian Mixture Model will predict the cluster labels for new instances.