[MINOR] RmVar disable for federated read data.#1110
Conversation
|
|
adding ternary aggregates is fine, but has nothing to do with the title of disabling rmvar right? Regarding the deleted wait on cleanup, please be aware that this might require federated worker changes as now they have to deal with concurrent RPC on a single execution context (not just concurrent RPC on different execution contexts that are managed in a concurrent hashmap). So it has a chance of brittle failures when these RPCs conflict on symbol table updates. |
|
Yes, I have realized that, i have simply gone back to having a background thread doing the cleanup. |
no ternary has nothing to do with the pr.. but it was one of the operation s making L2SVM slow, so i just added it. |
This commit adds Federated Ternary Aggregation, as well as change the federated cleanup, to run in separated threads. The latter improve the system performance by synchronizing and cleaning workers in parallel with computation continuing. Also a minior syntax error is corrected in builtin l2svm. closes apache#1110
No description provided.