Skip to content

builtIn outlierByArima function #1149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
juulez wants to merge 1 commit into from
Closed

builtIn outlierByArima function #1149

juulez wants to merge 1 commit into from

Conversation

@juulez
Copy link
Contributor

@juulez juulez commented Jan 9, 2021

added the builtIn outlierByArima function, which focuses on the AR part

@mboehm7
Copy link
Contributor

mboehm7 commented Jan 9, 2021

LGTM. That's awesome - thanks for the patch @juulez. During the merge, I only made some minor tweaks regarding formatting and warnings, and changed (rowMaxs(outlierFilter) == 0) to (outlierFilter == 0) as this filter is always a column vector (just for readability as the compiler would anyway simplify this).

@asfgit asfgit closed this in 6bb9a0d Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@juulez @mboehm7