[SYSTEMDS-2766] Federated covariance #1150
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baunsgaard
reviewed
Jan 13, 2021
Contributor
Baunsgaard
left a comment
Baunsgaard
left a comment
There was a problem hiding this comment.
The content is okay, but lacks cleanup. I would suggest to try to split up your implementation into more methods.
And make sure that the different parts are tested. You can use jacoco to verify this, simply add the -Djacoco.skip=false to your IDE. then you will get the log files in target that you can open in HTML
src/main/java/org/apache/sysds/runtime/instructions/fed/CovarianceFEDInstruction.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/sysds/runtime/instructions/fed/CovarianceFEDInstruction.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/sysds/runtime/instructions/fed/CovarianceFEDInstruction.java
Outdated
Show resolved
Hide resolved
src/test/java/org/apache/sysds/test/functions/federated/primitives/FederatedCovarianceTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/apache/sysds/test/functions/federated/primitives/FederatedCovarianceTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/apache/sysds/test/functions/federated/primitives/FederatedCovarianceTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/apache/sysds/test/functions/federated/primitives/FederatedCovarianceTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/apache/sysds/test/functions/federated/primitives/FederatedCovarianceTest.java
Show resolved
Hide resolved
src/test/scripts/functions/federated/FederatedCovarianceTest.dml
Outdated
Show resolved
Hide resolved
src/test/scripts/functions/federated/FederatedCovarianceTestReference.dml
Outdated
Show resolved
Hide resolved
OlgaOvcharenko
changed the title
OlgaOvcharenko
changed the title
Contributor
Author
|
@Baunsgaard I cleaned the code, can you take another look? Thanks. |
Contributor
|
LGTM, will merge shortly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds federated covariance instruction.