Closed
Conversation
sebwrede
reviewed
Feb 1, 2021
Contributor
sebwrede
left a comment
sebwrede
left a comment
There was a problem hiding this comment.
It looks good. I only have a few comments, mostly related to code style.
src/main/java/org/apache/sysds/runtime/instructions/fed/QuaternaryWCeMMFEDInstruction.java
Outdated
Show resolved
Hide resolved
src/test/java/org/apache/sysds/test/functions/federated/algorithms/FederatedPNMFTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/apache/sysds/test/functions/federated/algorithms/FederatedPNMFTest.java
Show resolved
Hide resolved
Contributor
Author
|
Thanks for the comments @sebwrede. I changed it properly :) |
Contributor
|
LGTM |
…struction in checkAndReplaceSP() fix(BinaryMatrixMatrixFEDInstruction.java): change broadcast of mo2 to broadcast sliced feat(FedLogical): add tests for federated logical MatrixScalar and MatrixMatrix instructions fix(alsCG): add check for heavy hitter "fed_!=" - now supported for SPARK too :)
…dcasting sliced chore(fedLogical): ignore the MatrixMatrix tests - keep the MatrixScalar Tests
…t is a matrix and row partitioned distinguish the case where mo2 is a column vector --> don't broadcast slice even if it is row partioned chore(FedLogical): remove ignores of MatrixMatrix tests
…e code and create else for error chore(FedPNMF): use parameter sparsity for generating random matrices remove parameter test_name (==> only one test name for pnmf, not needed as parameter here)
… test, FedPNMF test, and all quaternary primitive tests
Contributor
|
LGTM - during the merge, I just slightly modified some formatting including the license of the new test, which had tabs between the different sentences. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This is a PR for adding federated PNMF as an algorithm-level test for federated quaternary operations.
I also added checks for row partitioned federated data in the federated quaternary instructions.
Thanks for review :)