Denial Constraints#1188
Closed
clarapueyoballarin wants to merge 2 commits intoapache:masterfrom
clarapueyoballarin:master
Closed
Denial Constraints#1188clarapueyoballarin wants to merge 2 commits intoapache:masterfrom clarapueyoballarin:master
clarapueyoballarin wants to merge 2 commits intoapache:masterfrom
clarapueyoballarin:master
Conversation
Contributor
|
Hi, |
corepointer
requested changes
Feb 24, 2021
Contributor
corepointer
left a comment
There was a problem hiding this comment.
- Thanks for the PR, already looks promising. Some code to test it, as @Shafaq-Siddiqi already said, would be very appreciated :) Have a look at other builtins test functions do it and create a test class like the ones in src/test/java/org/apache/sysds/test/functions/builtin/*
- In addition to the indentation, some variables could have a more descriptive name.
- Please correct constrains to constraints.
Contributor
|
LGTM, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new .dml script for denial constrains calculation
Added its implementation for the builtins