Skip to content

Denial Constraints#1188

Closed
clarapueyoballarin wants to merge 2 commits intoapache:masterfrom
clarapueyoballarin:master
Closed

Denial Constraints#1188
clarapueyoballarin wants to merge 2 commits intoapache:masterfrom
clarapueyoballarin:master

Conversation

@clarapueyoballarin
Copy link
Contributor

Added new .dml script for denial constrains calculation
Added its implementation for the builtins

@Shafaq-Siddiqi
Copy link
Contributor

Hi,
Thank you for your contribution. Please add the tests in our test suite for your built-in. For the DML scripts, we use two-space indentation. If you are still working on the project please mark it as "WIP".

Copy link
Contributor

@corepointer corepointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Thanks for the PR, already looks promising. Some code to test it, as @Shafaq-Siddiqi already said, would be very appreciated :) Have a look at other builtins test functions do it and create a test class like the ones in src/test/java/org/apache/sysds/test/functions/builtin/*
  • In addition to the indentation, some variables could have a more descriptive name.
  • Please correct constrains to constraints.

@clarapueyoballarin clarapueyoballarin changed the title Denial Constrains [WIP] Denial Constraints Feb 24, 2021
@Shafaq-Siddiqi Shafaq-Siddiqi changed the title [WIP] Denial Constraints Denial Constraints Mar 12, 2021
@Shafaq-Siddiqi
Copy link
Contributor

LGTM,
Thank you @clarapueyoballarin for your contribution. During the merge, I have fixed some minor formatting, warnings, and header of the DML script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants