Updating pom.xml to have variables of hadoop and antlr versions and to remove tailing spaces. #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o remove tailing spaces.
Contributor
|
Test build started here. |
Contributor
|
Hi, thanks for contributing this! As usual, I've started a test build, and pending the results of that, this looks good to me. |
Contributor
Author
|
@dusenberrymw thank you for the review. The test looks to be passed? |
Contributor
|
Testing successful. |
Contributor
|
Merged. Thanks, @oza! |
Contributor
Author
|
Thank you for committing :-) |
asfgit
pushed a commit
that referenced
this pull request
Mar 27, 2020
image processing operations brightness, crop, mirror and their respective junit tests Closes #12.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating pom.xml to have variables for versions of hadoop and antlr and to remove tailing spaces.
The versions of Hadoop and antlr are used in multiple sections manually: this PR fixes it and changes to use variable - hadoop.version and antlr.version.
We can also pass the version as arguments of maven command like
mvn clean package -Dhadoop.verion=2.4.1.