[SYSTEMDS-2889] Add initial lineage debugger for CP instructions#1286
Closed
bnyra wants to merge 3 commits intoapache:masterfrom
Closed
[SYSTEMDS-2889] Add initial lineage debugger for CP instructions#1286bnyra wants to merge 3 commits intoapache:masterfrom
bnyra wants to merge 3 commits intoapache:masterfrom
Conversation
This patch adds a lineage based debugger which keeps track of special values in matrixblocks in CP instructions.
Check LINEAGE_DEBUGGER for explain lineage item
Contributor
|
Thanks for the patch @bnyra. Before merging, I moved the debugging-related maintenance from Instruction to CPInstruction as calling acquireRead can be problematic for federated and GPU instructions, and removed serialization of the debug byte if debugger is disabled. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds a lineage based debugger which keeps track of special values in matrixblocks in CP instructions.
Therefore, the following design decisions are made and implemented:
LINEAGE_DEBUGGERflag as DMLScript option to enable the debugger (default: false)class BooleanArray32for storing boolean information in an memory efficient way_specialValueBitsinLineageItemto store the special value informationpostprocessInstruction()_specialValueBitswith surrounding bracketsLineageItem.Additional info:
Double.NaN,Double.POSITIVE_INFINITYandDouble.NEGATIVE_INFINITYCPInstructionandGPUInstruction