[SYSTEMDS-2854] SUM_SQ reduction for GPU-codegen fixed; cleanups#1315
Closed
corepointer wants to merge 1 commit intoapache:masterfrom
Closed
[SYSTEMDS-2854] SUM_SQ reduction for GPU-codegen fixed; cleanups#1315corepointer wants to merge 1 commit intoapache:masterfrom
corepointer wants to merge 1 commit intoapache:masterfrom
Conversation
This patch re-enables the reduction operation for GPU, which was (unnecessarily) disabled because it did not work correctly with cuda codegen. A few cleanups in the touched files went in alongside.
corepointer
force-pushed
the
SYSTEMDS-2854
branch
from
e15ce41 to
b022775
Compare
ilovemesomeramen
pushed a commit
to ilovemesomeramen/systemds
that referenced
this pull request
Jul 21, 2021
This patch re-enables the reduction operation for GPU, which was (unnecessarily) disabled because it did not work correctly with cuda codegen. A few cleanups in the touched files went in alongside. Closes apache#1315
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch re-enables the reduction operation for GPU, which was (unnecessarily) disabled because it did not work correctly with cuda codegen.
A few cleanups in the touched files went in alongside.