Nbatches parameter#1365
Closed
atefeh-asayesh wants to merge 9 commits intoapache:masterfrom
atefeh-asayesh:NbatchesParameter
Closed
Nbatches parameter#1365atefeh-asayesh wants to merge 9 commits intoapache:masterfrom atefeh-asayesh:NbatchesParameter
atefeh-asayesh wants to merge 9 commits intoapache:masterfrom
atefeh-asayesh:NbatchesParameter
Conversation
…tches to extend paramserv builtin for NBATCH updates. In this step it has been implemented for both local (computeNBatches(dataSize, batchIter)) and federated parameter servers (computeWithNBatchUpdates in FederatedPSControlThread.java).
…tches to extend paramserv builtin for NBATCH updates. In this step it has been implemented for both local (computeNBatches(dataSize, batchIter)) and federated parameter servers (computeWithNBatchUpdates in FederatedPSControlThread.java).
…tches to extend paramserv builtin for NBATCH updates. In this step it has been implemented for both local (computeNBatches(dataSize, batchIter)) and federated parameter servers (computeWithNBatchUpdates in FederatedPSControlThread.java).
…tches to extend paramserv builtin for NBATCH updates. In this step it has been implemented for both local (computeNBatches(dataSize, batchIter)) and federated parameter servers (computeWithNBatchUpdates in FederatedPSControlThread.java).
…tches to extend paramserv builtin for NBATCH updates. In this step it has been implemented for both local (computeNBatches(dataSize, batchIter)) and federated parameter servers (computeWithNBatchUpdates in FederatedPSControlThread.java).
Contributor
Author
|
Draft- Some small changes would be done. |
…tches to extend paramserv builtin for NBATCH updates. Draft- Some small changes would be done.
…tches to extend paramserv builtin for NBATCH updates. Draft- Some small changes would be done.
…tches to extend paramserv builtin for NBATCH updates. In this step, It has been implemented for both local (computeNBatches(dataSize, batchIter)) and federated parameter servers (computeWithNBatchUpdates in FederatedPSControlThread.java).
Contributor
|
LGTM - thanks @atefeh-asayesh for the extension of the parameter server. During the merge I mode the following changes:
|
Contributor
|
Let's close this PR as it was merged with #1382 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we add freq=NBATCHES along with the optional parameter nbatches to extend paramserv builtin for NBATCH updates.
In this step, It has been implemented for both local (computeNBatches(dataSize, batchIter)) and federated parameter servers (computeWithNBatchUpdates in FederatedPSControlThread.java).