Skip to content

[MINOR] Add dry run to pypi upload script#1423

Merged
j143 merged 2 commits intoapache:masterfrom
j143:pypi-fixes
Oct 26, 2021
Merged

[MINOR] Add dry run to pypi upload script#1423
j143 merged 2 commits intoapache:masterfrom
j143:pypi-fixes

Conversation

@j143
Copy link
Copy Markdown
Member

@j143 j143 commented Oct 26, 2021

Usage:

For publish to test.pypi.org

./dev/release/pypi-upload.sh -n

Publish to pypi.org

./dev/release/pypi-upload.sh

🌩 Includes a logic for updating version name to 2.2.0 instead of 2.2.0-rc1 for the approved candidate.

@phaniarnab
Copy link
Copy Markdown
Contributor

The dry run for pypi upload is to upload to testpypi. Is this change enabling that?
For python package however some amount of manual testing is needed to make sure if the package is installable via pip and working.

@j143
Copy link
Copy Markdown
Member Author

j143 commented Oct 26, 2021

The dry run for pypi upload is to upload to testpypi. Is this change enabling that?

Yes, it does.

For python package however some amount of manual testing is needed to make sure if the package is installable via pip and working.

Sure, I will try to add this one as a check.

@j143 j143 merged commit 8df051f into apache:master Oct 26, 2021
@j143 j143 deleted the pypi-fixes branch October 26, 2021 18:28
j143 added a commit to j143/systemds that referenced this pull request Nov 10, 2021
* add release version changes after the release candidate approval
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants