[SYSTEMDS-3217] PythonAPI working with SYSTEMDS_ROOT set#1454
Closed
Baunsgaard wants to merge 1 commit into
Closed
[SYSTEMDS-3217] PythonAPI working with SYSTEMDS_ROOT set#1454Baunsgaard wants to merge 1 commit into
Baunsgaard wants to merge 1 commit into
Conversation
phaniarnab
reviewed
Nov 12, 2021
Contributor
phaniarnab
left a comment
phaniarnab
left a comment
There was a problem hiding this comment.
General comment: Please stick to only bug fixes/absolutely necessary changes for the patch release. Code changes in a new RC should only contain the fixes missing in the last RC.
j143
reviewed
Nov 12, 2021
Member
|
Thank you for the cleanup. |
Contributor
Author
yes that is the next task, i will take the appropriate parts from this, and make specific targeted changes for the release branch |
Baunsgaard
force-pushed
the
PythonBuildFixes
branch
2 times, most recently
from
e64f9b6 to
c10f4e6
Compare
This commit modify the PythonAPI at startup to work with our release binaries. While modifying this the building of the python release artifact have been modified to not include the test and generator code. This commit also contains changes so that we can specify a config in python [MINOR] .gitignore specific for python [SYSTEMDS-3216] Cleanup python build to not include excessive files This commit change the python building to not include tests, generator python scripts. The tutorial datasets are now also ignored for the releases. And the construction of the context, now support SYSTEMDS_ROOT set or not. to either a release artifact or a source clone of systemds. This commit also contain a small fix for list reading and writing to construct the correct object types in python. To improve test environment and startup the systemds_context now have multiple phases and checks on startup making the experience much smoother This also allowed to change the python tests to run fully parallel, and therefore the changes to do so is done.
Baunsgaard
force-pushed
the
PythonBuildFixes
branch
from
9c876a3 to
7b742f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit modify the PythonAPI at startup to work with our release
binaries. While modifying this the building of the python release
artifact have been modified to not include the test and generator code.